-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: convert multihost/alltests/test_cache_testing to system/memory_cache #7103
Conversation
a979db8
to
d4f0d2c
Compare
c2e2088
to
e4034f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e4034f9
to
8040790
Compare
I know this is merely a port of 821455c that in turn is a port of bash(?) tests, but:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the tests overlap
https://github.com/SSSD/sssd/blob/master/src/tests/system/tests/test_sss_cache.py
Except the last two tests and those I think should be consolidated into one so it's cleaner. More detail in the comments.
Not part of this PR, but a note.
What we are missing is the functional part of the cache tests. We have one test that sort of does it.
test_authentication__offline_login
It configures parameters and doesn't use the default. We should always have a vanilla functional test.
8040790
to
f3ad769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been doing some house keeping/auditing of tests in the new test frame. Please take a look at this pull request, #7160
A lot of tests that you have ported, thank you for porting them. They're going to be renamed and need to be re-evaulted because it may have been a poor test case to begin with.
666a1f5
to
3c6b265
Compare
3c6b265
to
a4ab47b
Compare
Converted another bunch of tests.