KCM uses its own configuration

[aplopez]

• CONFDB: Fixed some missing dependencies in a header file
  This header file was missing some #includes it needs.

• CONFDB: Allow loading an empty configuration
  This is done with a parameter. The old behavior is kept for the other components than KCM.

• UTILS: Add the db file name to server_setup()'s parameters
  Helper for the last commit.

• UTILS: Create a macro for the --config option
  Helper for the last commit.

• KCM handles its own configuration
  KCM now uses the ${SSS_STATEDIR}/db/config_kcm.ldb database to store its configuration.
  config.ldb is no longer used by KCM.

Resolves: #6926

[alexey-tikhonov]

Please rebase on the top of latest 'master'. Some CI failures should be fixed.

[alexey-tikhonov]

What bothers me is that 'config_kcm.ldb' will have entire 'sssd.conf' content while it only needs '[kcm]' section.
Would it be possible to save only [kcm] to ldb?

[aplopez]

What bothers me is that 'config_kcm.ldb' will have entire 'sssd.conf' content while it only needs '[kcm]' section. Would it be possible to save only [kcm] to ldb?

It only has the [kcm] section. load_configuration()'s third parameter is only_section and the value kcm is passed.

[alexey-tikhonov]

What bothers me is that 'config_kcm.ldb' will have entire 'sssd.conf' content while it only needs '[kcm]' section. Would it be possible to save only [kcm] to ldb?

It only has the [kcm] section. load_configuration()'s third parameter is only_section and the value kcm is passed.

I'm removing it in #6908...
Ok, then I'll have to deal with it.

[alexey-tikhonov]

Now when #6924 was merged, could you please rebase again?

[aplopez]

Now when #6924 was merged, could you please rebase again?

Done

[aplopez]

All failing test are doing so because of external reasons.

[justin-stephenson]

KCM configuration is still stored in config.ldb in addition to the new config_kcm.ldb - is it intended?

# ldbsearch -H /var/lib/sss/db/config.ldb -b 'cn=kcm,cn=config'
# record 1
dn: cn=kcm,cn=config
cn: kcm
debug_level: 9
distinguishedName: cn=kcm,cn=config

Will removing --genconf-section/--genconf entirely be done in another PR later?

[alexey-tikhonov]

Will removing --genconf-section/--genconf entirely be done in another PR later?

Here - #6908

[alexey-tikhonov]

KCM configuration is still stored in config.ldb in addition to the new config_kcm.ldb - is it intended?

Ideally 'sssd_kcm' should have its own config file (and there are not many reason to name it 'sssd_' actually).

But transition to new config file should be gradual, we should keep supporting sssd.conf for kcm server - to avoid breaking existing setups.

I'm not sure if it's worth the effort to make sure [kcm] section doesn't get unto sssd's config.ldb...

[aplopez]

KCM configuration is still stored in config.ldb in addition to the new config_kcm.ldb - is it intended?

Ideally 'sssd_kcm' should have its own config file (and there are not many reason to name it 'sssd_' actually).

But transition to new config file should be gradual, we should keep supporting sssd.conf for kcm server - to avoid breaking existing setups.

I'm not sure if it's worth the effort to make sure [kcm] section doesn't get unto sssd's config.ldb...

If we are going that way, I think we should create a separate ticket and do all those changes separately and properly instead of using this PR.

[alexey-tikhonov]

KCM now uses the /var/lib/sss/db/config_kcm.ldb database ...

This is actually %{sssdstatedir}/db, might be configured differently on other platforms.

[aplopez]

KCM now uses the /var/lib/sss/db/config_kcm.ldb database ...

This is actually %{sssdstatedir}/db, might be configured differently on other platforms.

True. I will correct the description.

[alexey-tikhonov]

A couple of minor comments, otherwise looks good to me.

[justin-stephenson]

Ack, thank you.

[alexey-tikhonov]

KCM now uses the /var/lib/sss/db/config_kcm.ldb database ...

This is actually %{sssdstatedir}/db, might be configured differently on other platforms.

True. I will correct the description.

Latest version still references /var/lib/sss/db/config_kcm.ldb'

[aplopez]

KCM now uses the /var/lib/sss/db/config_kcm.ldb database ...

This is actually %{sssdstatedir}/db, might be configured differently on other platforms.

True. I will correct the description.

Latest version still references /var/lib/sss/db/config_kcm.ldb'

Can you please be more specific? Where is /var/lib/sss/db/config_kcm.ldb referenced?

[alexey-tikhonov]

KCM now uses the /var/lib/sss/db/config_kcm.ldb database ...

This is actually %{sssdstatedir}/db, might be configured differently on other platforms.

True. I will correct the description.

Latest version still references /var/lib/sss/db/config_kcm.ldb'

Can you please be more specific? Where is /var/lib/sss/db/config_kcm.ldb referenced?

In the commit message of KCM: Handle its own configuration patch.

[aplopez]

In the commit message of KCM: Handle its own configuration patch.

Fixed.

[alexey-tikhonov]

Thanks, ACK.

[alexey-tikhonov]

Pushed PR: #6948

• master
  • 0485342 - KCM: Handle its own configuration
  • e6c1d3a - CONFDB: Fixed some missing dependencies in a header file
  • 7cc28f3 - CONFDB: Allow loading an empty configuration
  • 049edef - UTILS: Add the db file name to server_setup()'s parameters
  • 22f8eee - UTILS: Create a macro for the --config option