TESTS: Adapt the KCM tests to the new behavior #6980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplopez
force-pushed
the
kcm-config
branch
6 times, most recently
from
aea5953 to
92e8fef
Compare
Logs were not included in the artifacts because the path was incorrect.
aplopez
force-pushed
the
kcm-config
branch
3 times, most recently
from
0a108f2 to
50b348a
Compare
aplopez
changed the title
|
Centos-9 system test seem to be failing because of a dependency problem not related to this PR. |
Hi, jfyi, the issue on Debian should be fixed by SSSD/sssd-ci-containers#64 . bye, |
thalman
requested changes
Oct 24, 2023
Tests where sometimes failing because they were opening the pipe while KCM was shutting down. This was happening because tests were successfully opening the pipe because it was left over by the previous instance of KCM. So to avoid this we immediately remove the pipe during teardown. With this, tests will fail to open it and keep trying until it is re-created by the new instance of KCM.
Some PAM tests sometimes fail because they starts before KDC has finished its initialization. Adding a short delay to let it complete its initialization before launching the actual tests.
thalman
approved these changes
Oct 24, 2023
alexey-tikhonov
added
Accepted
backport-to-stable
and removed
no-backport
|
@danlavu, would you like to take a look at updated version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests started to fail sporadically after KCM uses its own configuration #6948 was pushed, because the start-up time is now longer.