Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tai64: v4.0.1 #1591

Closed
wants to merge 1 commit into from
Closed

tai64: v4.0.1 #1591

wants to merge 1 commit into from

Conversation

baloo
Copy link
Member

@baloo baloo commented Oct 29, 2024

Fixed

@baloo
tai64: v4.0.1
1c54efd 
Fixed
- fix TAI offset and verify with GH Action (RustCrypto#1583)
@baloo baloo mentioned this pull request Oct 29, 2024
Closed
tarcieri
tarcieri requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I take it back, it was marked v5.0.0-pre due to the MSRV bump here: #802

That's definitely worth noting in the CHANGELOG, but also per our SemVer policy it doesn't need a major version bump, only a minor one.

So this release should probably be v4.1.0 due to the MSRV bump.

@tarcieri tarcieri mentioned this pull request Oct 29, 2024
Merged
@baloo
Copy link
Member Author

baloo commented Oct 29, 2024

I forgot about MSRV.

Let's go with #1590 then

@baloo baloo closed this Oct 29, 2024
@baloo baloo deleted the baloo/tai64/v4.0.1 branch October 29, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baloo @tarcieri