Add new action to update leap seconds automatically #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Oct 23, 2024
|
I think we should just put out patch releases that correct the time offset |
|
@tarcieri Thanks a lot for the fast merge. Can we expect a release for the first update that has been done in this PR ? :) |
|
@tarcieri Hello, any news about a possible release for this fix ? |
baloo
added a commit
to baloo/formats
that referenced
this pull request
Oct 29, 2024
Changed - bump zeroize from 1.4.2 to 1.4.3 (RustCrypto#187) - Lint improvements (RustCrypto#824) - bump zeroize from 1.5.7 to 1.6.0 (RustCrypto#956) - bump zeroize from 1.7.0 to 1.8.1 (RustCrypto#1419) Fixed - fix TAI offset and verify with GH Action (RustCrypto#1583)
Closed
baloo
added a commit
to baloo/formats
that referenced
this pull request
Oct 29, 2024
Fixed - fix TAI offset and verify with GH Action (RustCrypto#1583)
Merged
baloo
added a commit
to baloo/formats
that referenced
this pull request
Oct 29, 2024
Fixed - fix TAI offset and verify with GH Action (RustCrypto#1583)
Closed
|
#1591 is open but it's been a bit tricky because of how long it's been since a release |
baloo
added a commit
to baloo/formats
that referenced
this pull request
Oct 29, 2024
Fixed - fix TAI offset and verify with GH Action (RustCrypto#1583)
baloo
added a commit
that referenced
this pull request
Oct 29, 2024
Fixed - fix TAI offset and verify with GH Action (#1583)
5 tasks
AurelienFT
added a commit
to FuelLabs/fuel-core
that referenced
this pull request
Oct 30, 2024
## Linked Issues/PRs #2338 RustCrypto/formats#1583 RustCrypto/formats#1590 ## Description I have fixed the wrong offset and added an automation for future update in crate `tai64`(RustCrypto/formats#1583) and they merged it and made a new release (RustCrypto/formats#1590). This PR updates to the new version. ## Checklist - [x] Breaking changes are clearly marked as such in the PR description and changelog - [x] New behavior is reflected in tests - [x] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [x] I have reviewed the code myself - [x] I have created follow-up issues caused by this PR and linked them here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #675
This PR adds a github actions that runs each week, to check for the leap seconds change in a reputable source and creates a PR to update if necessary.
The PR doesn't contains the process to release automatically as the process could change and maybe we don't want to directly change the version and make the release.
This current PR also include the changes to start with the current value 37 seconds.
Here is some tests I did on a fork : https://github.com/AurelienFT/formats/actions/runs/11470018305/job/31918401654 / https://github.com/AurelienFT/formats/pull/5/files
It could be nice to release a new major this time to have the correct time available for everyone.