Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Upgrade stable_baselines3_internal to latest release v2.1.0 #20147

Conversation

BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail commented Sep 7, 2023

Towards #20108


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator

Ah, this is a silly patch file, it will always fail to apply.

I'll take this over and make a better patching strategy.

@jwnimmer-tri jwnimmer-tri self-assigned this Sep 7, 2023
@jwnimmer-tri jwnimmer-tri removed their assignment Sep 7, 2023
@jwnimmer-tri jwnimmer-tri added status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Sep 7, 2023
@jwnimmer-tri
Copy link
Collaborator

+@EricCousineau-TRI for both reviews per schedule, please.

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: x2!

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)

@EricCousineau-TRI EricCousineau-TRI added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Sep 7, 2023
@EricCousineau-TRI EricCousineau-TRI merged commit d9ce70b into RobotLocomotion:master Sep 7, 2023
1 check passed
@BetsyMcPhail BetsyMcPhail deleted the upgrade-stable_baselines3_internal branch September 7, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants