[common] Provide drake_export and opt-in to Werror=attributes #18677
Conversation
jwnimmer-tri
added
release notes: none
|
@drake-jenkins-bot mac-x86-monterey-clang-bazel-experimental-release please |
|
+@rpoyner-tri for feature review, please. |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee ggould-tri(platform) (waiting on @ggould-tri and @jwnimmer-tri)
common/drake_export.h line 31 at r1 (raw file):
</pre> To un-export juse one function:
typo
Suggestion:
just
As we start to be more careful with linker visibility, it's becoming ever more likely that -Wattributes warnings will leak to the console. Promote them to errors so that we see them and fix the problem.
jwnimmer-tri
force-pushed
the
wattributes
branch
from
7e6aa08 to
757a3a1
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee ggould-tri(platform) (waiting on @ggould-tri)
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),ggould-tri(platform) (waiting on @jwnimmer-tri)
…ocomotion#18677) As we start to be more careful with linker visibility, it's becoming ever more likely that -Wattributes warnings will leak to the console. Promote them to errors so that we see them and fix the problem.
…ocomotion#18677) As we start to be more careful with linker visibility, it's becoming ever more likely that -Wattributes warnings will leak to the console. Promote them to errors so that we see them and fix the problem.
…ocomotion#18677) As we start to be more careful with linker visibility, it's becoming ever more likely that -Wattributes warnings will leak to the console. Promote them to errors so that we see them and fix the problem.
…ocomotion#18677) As we start to be more careful with linker visibility, it's becoming ever more likely that -Wattributes warnings will leak to the console. Promote them to errors so that we see them and fix the problem.
As we start to be more careful with linker visibility, it's becoming ever more likely that
-Wattributeswarnings will leak to the console. Promote them to errors so that we see them and fix the problem.Towards #17231.
This change is