Skip to content

Commit

Permalink
Revert "[common] Provide drake_export and opt-in to Werror=attributes (
Browse files Browse the repository at this point in the history
…RobotLocomotion#18677)"

This reverts commit 9fb09b4.
  • Loading branch information
liangfok committed Jan 31, 2023
1 parent 2f14eaf commit 6be1781
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 50 deletions.
6 changes: 0 additions & 6 deletions common/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ drake_cc_package_library(
":diagnostic_policy",
":double",
":drake_bool",
":drake_export",
":drake_path",
":dummy_value",
":essential",
Expand Down Expand Up @@ -191,11 +190,6 @@ drake_cc_library(

# Miscellaneous utilities.

drake_cc_library(
name = "drake_export",
hdrs = ["drake_export.h"],
)

drake_cc_library(
name = "identifier",
srcs = ["identifier.cc"],
Expand Down
39 changes: 0 additions & 39 deletions common/drake_export.h

This file was deleted.

1 change: 0 additions & 1 deletion geometry/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,6 @@ drake_cc_library(
"//perception:point_cloud",
],
deps = [
"//common:drake_export",
"//common:find_resource",
"//common:scope_exit",
"//common:unused",
Expand Down
7 changes: 4 additions & 3 deletions geometry/meshcat.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include <drake_vendor/uuid.h>
#include <fmt/format.h>

#include "drake/common/drake_export.h"
#include "drake/common/drake_throw.h"
#include "drake/common/find_resource.h"
#include "drake/common/never_destroyed.h"
Expand Down Expand Up @@ -1089,8 +1088,10 @@ class Meshcat::Impl {
});
}

// This function is public via the PIMPL.
DRAKE_NO_EXPORT void SetAnimation(const MeshcatAnimation& animation) {
// This function is public via the PIMPL. We'll set linker visibility to
// avoid a warning about our std::visit's lambda capture of a msgpack object.
__attribute__((visibility("hidden")))
void SetAnimation(const MeshcatAnimation& animation) {
DRAKE_DEMAND(IsThread(main_thread_id_));

std::stringstream message_stream;
Expand Down
1 change: 0 additions & 1 deletion tools/skylark/drake_cc.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ load("//tools/skylark:kwargs.bzl", "incorporate_num_threads")
# building with any compiler.
CXX_FLAGS = [
"-Werror=all",
"-Werror=attributes",
"-Werror=cpp",
"-Werror=deprecated",
"-Werror=deprecated-declarations",
Expand Down

0 comments on commit 6be1781

Please sign in to comment.