Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminator nl master #6

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Terminator nl master #6

wants to merge 23 commits into from

Conversation

RobertJansen1
Copy link
Owner

No description provided.

@RobertJansen1
Copy link
Owner Author

RobertJansen1 commented Apr 2, 2024

@TerminatorNL @Dennis-Q can you both check this branch and see if all is still functional (both new features of @TerminatorNL as old (set troom api) thanks in advance! As i don't use both, its hard for me to test

@Dennis-Q
Copy link

Dennis-Q commented Apr 8, 2024

Hi @RobertJansen1,

Not sure what is happening but I can't get it to compile:

INFO ESPHome 2024.3.1
INFO Reading configuration /config/esphome/acwoonkamertest.yaml...
Failed config

climate.custom: [source /config/esphome/acwoonkamertest.yaml:64]
  platform: custom
  lambda: !lambda |-
    auto mhi_ac_ctrl = new MhiAcCtrl();
    App.register_component(mhi_ac_ctrl);
    return {mhi_ac_ctrl};
  climates: 
    - name: ''
      
      ID acwoonkamertest redefined! Check climate->0->climates->0->id.
      id: acwoonkamertest
      disabled_by_default: False
      visual: {}

I'm using the latest updates from this branch.

I created a new device 'acwoonkamertest', copied over the yaml-file from this git and adjusted:

# Version 2.2
substitutions:
  # Unique device ID in HA
  deviceid: "acwoonkamertest"
  # Unique device name in HA
  devicename: "ACwoonkamerTest"
  # The WiFi network to connect to
  wifi_ssid: !secret wifi_ssid
  # The WiFi password
  wifi_password: !secret wifi_password
  # Web auth username
  username: !secret web_username
  # Web auth password
  password: !secret web_password

Any idea? Not really have much time to dig into it currently.

@Dennis-Q
Copy link

Ah.. so it seems this branch is missing the latest fix to remove the climate: component from the yaml file. To be more precise: commit 8c73b63.

I'll manually fix this and try to run it soon.

@Dennis-Q
Copy link

Dennis-Q commented Apr 10, 2024

So it is running, but since there is no reason for heating right now (and there hasn't been in the last days), I can't really compare it (yet) with my previous days. I'll keep it running and hope I can do some testing in the next days.

@Dennis-Q
Copy link

Yes, I can confirm set temperature with external sensor is still working as expected! Finally some days which needed some heating.

Not sure what your changes intent to do, haven't really looked into it yet either.

@SkullboyNL
Copy link

I've been running this for 2 weeks now on a split system with 2 indoor units and it works perfectly. Thanks so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants