check work for low temp heating #5
Conversation
…ains debugging switches that need to be removed before release.
|
Better not remove the option for external temperature sensor! I use it with my zigbee temp sensor and it works so much better then the internal sensor! |
|
I am checking the code out in MR #6 i will see if i can keep the external room temperature and why it was removed. @TerminatorNL can maybe comment as well? |
|
Hi @RobertJansen1, I want to thank you so much for picking this up. I've been looking at my email notifications all day today and it looks like you're making great progress. The reason I took out the external room temperature setting was because I was building a proof of concept and did not want to further complicate the math and logic since I was actively using the room temperature variable to communicate with the AC. I saw that you are well on your way in undoing that change, which surely is the right call for a production environment 👍 Regarding d2783ca, I was running into compiler errors and just commented it out so I could test the proof of concept without getting held up. You're making the right call to undo that change as well. You've probably figured out by now that my code was not intended to be a PR, but you're still making efforts to credit me for these changes, thank you. I only wish I had the time to make a proper PR for you so you wouldn't have to deal with my messy changes. I'm a bit overwhelmed right now, but if there's any specific things you're running into; I am willing to elaborate. It does appear that you've got it covered at this point and for that I am very grateful. |
|
Well, I want to thank you for the initial work and adding the functionality! I wanted to get started on the low temp heating and more precise target but was to busy to do so, now I got a good reason. I think for now it is up to testing. I have not yet used am external room temp sensor, and by reading this I think you have. It would be very nice if you can test the most recent changes and see if I didn't break anything. There were some oddities which were fixed but could have an impact on the inner workings for example ginkage@c4958bd ginkage@cf02da6 |
|
I unfortunately don't have either an external room temperature sensor or on-board sensor. I'm running exclusively off of the internal room temperature sensor inside the AC. This complicates testing those code paths for me as well... |
No description provided.