-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StackOverflowError coming from MOI.Utilities.operate
#6
Conversation
as discussed here - let's attempt to fix this upstream in MOI rather than adding to the complexity of SolverAPI |
The MOI fix jump-dev/MathOptInterface.jl#2285 unblocks us for the test case added here, so lets get the test case in after MOI is tagged and leave this PR up here as DNMY. Not super high priority but when we become more concerned with performance, I think we could attempt an even larger change here that builds the SAF/SQF/SNF directly bottom-up from the JSON3 data structure, rather than going through the SNF intermediate. Because right now we do JSON->SNF with |
@chriscoey Sure we can wait for the upstream fix. I'm leaving this PR open in case we want to improve the performance of |
Thanks @bachdavi. Let's keep working on this PR to try to extend it to go directly from JSON. Hopefully that will improve the efficiency even further. |
Since the upstream MOI fix is controversial, I decided to get this PR in rather than wait. We can further improve the performance in future PRs. I split out the JSON-to-MOI functions into a separate file to improve clarity. |
No description provided.