Add test for large models, free model memory, and require options field #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by jump-dev/MathOptInterface.jl#2288, so the first CI run should fail here.this is the same type of test failure triggered by #6, caused by a stack overflow from MOI.operate. but I made the test easier to work with because the model is set-up directly in the test rather than read from a JSON file, so you can change the size and expressions easily.
Thanks @bachdavi and @hdavid16
I also made the options field required - it should always be present anyway - and that simplified the code a little and improved type stability.
I also added a
MOI.empty!
to free the MOI model, whether there was an error or not.