Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for large models, free model memory, and require options field #8

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

chriscoey
Copy link
Member

@chriscoey chriscoey commented Sep 22, 2023

blocked by jump-dev/MathOptInterface.jl#2288, so the first CI run should fail here.

this is the same type of test failure triggered by #6, caused by a stack overflow from MOI.operate. but I made the test easier to work with because the model is set-up directly in the test rather than read from a JSON file, so you can change the size and expressions easily.

Thanks @bachdavi and @hdavid16

I also made the options field required - it should always be present anyway - and that simplified the code a little and improved type stability.

I also added a MOI.empty! to free the MOI model, whether there was an error or not.

@chriscoey
Copy link
Member Author

This fails locally but not on CI, so I'll try increasing n to break CI.

@chriscoey
Copy link
Member Author

reduced n so CI/local will pass so we can merge this, and in #6 we will increase n again

@chriscoey chriscoey changed the title Add test for large models Add test for large models, free model memory, and require options field Sep 22, 2023
@chriscoey chriscoey merged commit 6c8a85f into main Sep 22, 2023
3 checks passed
@chriscoey chriscoey deleted the cdc-big-sum-test branch September 22, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant