Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding relative & absolute mip gaps #17

Merged
merged 13 commits into from
Nov 3, 2023
Merged

adding relative & absolute mip gaps #17

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
74f7af0
mip gaps
zengjian-hu-rai Nov 1, 2023
0942e4e
check for abs gap
zengjian-hu-rai Nov 1, 2023
b45861f
Merge branch 'main' into RAI-17621-Return-MIP-relative-and-absolute-gap
zengjian-hu-rai Nov 1, 2023
70bfef1
fix broken tests
zengjian-hu-rai Nov 1, 2023
bd93b75
remove info
zengjian-hu-rai Nov 3, 2023
e129658
Merge branch 'main' into RAI-17621-Return-MIP-relative-and-absolute-gap
zengjian-hu-rai Nov 3, 2023
a7ce888
merge main
zengjian-hu-rai Nov 3, 2023
5e50c53
fix broken tests
zengjian-hu-rai Nov 3, 2023
199ed83
remove info lines
zengjian-hu-rai Nov 3, 2023
a620357
remove extra info and comments
zengjian-hu-rai Nov 3, 2023
982fef8
minor tweak per Chris' suggestion
zengjian-hu-rai Nov 3, 2023
677af3f
Update src/SolverAPI.jl
zengjian-hu-rai Nov 3, 2023
558fe68
report rel_gap if not inf
zengjian-hu-rai Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/SolverAPI.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,10 @@ function response(
result_count = MOI.get(model, MOI.ResultCount())

try
res["relative_gap"] = Float64(MOI.get(model, MOI.RelativeGap()))
if isinf(res["relative_gap"])
res["relative_gap"] = nothing # Inf cannot be serialized to JSON
res["relative_gap"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line?

rel_gap = Float64(MOI.get(model, MOI.RelativeGap()))
if isinf(rel_gap)
res["relative_gap"] = rel_gap# Inf cannot be serialized to JSON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res["relative_gap"] = rel_gap# Inf cannot be serialized to JSON
res["relative_gap"] = rel_gap # Inf cannot be serialized to JSON

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, it should be if !isinf(rel_gap)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

end
catch
# ignore if solver does not support relative gap
Expand Down