adding relative & absolute mip gaps #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscoey
reviewed
Nov 3, 2023
test/all_tests.jl
Outdated
| @@ -81,6 +81,8 @@ end | |||
| # solve and check output is expected for each input json file | |||
| @testset "$j" for j in json_names | |||
| output = JSON3.read(run_solve(read_json("inputs", j))) | |||
| @info output | |||
| #isdefined(Main, :Infiltrator) && Main.infiltrate(@__MODULE__, Base.@locals, @__FILE__, @__LINE__) | |||
There was a problem hiding this comment.
oh my goodness. thought i 've removed them. :)
chriscoey
reviewed
Nov 3, 2023
src/SolverAPI.jl
Outdated
| @@ -111,6 +111,16 @@ function response( | |||
| res["solve_time_sec"] = Float64(MOI.get(model, MOI.SolveTimeSec())) | |||
|
|
|||
| result_count = MOI.get(model, MOI.ResultCount()) | |||
|
|
|||
| try | |||
| res["relative_gap"] = Float64(MOI.get(model, MOI.RelativeGap())) | |||
There was a problem hiding this comment.
makes a little more sense to do
rel_gap = Float64(MOI.get(model, MOI.RelativeGap()))
and then only set res["relative_gap"] if it's finite.
There was a problem hiding this comment.
thanks. good point
chriscoey
approved these changes
Nov 3, 2023
chriscoey
reviewed
Nov 3, 2023
| res["relative_gap"] = Float64(MOI.get(model, MOI.RelativeGap())) | ||
| if isinf(res["relative_gap"]) | ||
| res["relative_gap"] = nothing # Inf cannot be serialized to JSON | ||
| res["relative_gap"] |
chriscoey
reviewed
Nov 3, 2023
src/SolverAPI.jl
Outdated
| res["relative_gap"] | ||
| rel_gap = Float64(MOI.get(model, MOI.RelativeGap())) | ||
| if isinf(rel_gap) | ||
| res["relative_gap"] = rel_gap# Inf cannot be serialized to JSON |
There was a problem hiding this comment.
Suggested change
| res["relative_gap"] = rel_gap# Inf cannot be serialized to JSON | |
| res["relative_gap"] = rel_gap # Inf cannot be serialized to JSON |
There was a problem hiding this comment.
oh, it should be if !isinf(rel_gap)?
Co-authored-by: Chris Coey <[email protected]>
|
nice! good to merge when green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://relationalai.atlassian.net/jira/software/c/projects/RAI/boards/41?search=jian&selectedIssue=RAI-17621
Added supports for relative_gap_tolerance and absolute_gap_tolerance, and the report of final relative_gap from solver. Note that MOI doesn't support reporting the final absolute gap.