-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convert quickstart #185
Merged
Hyperkid123
merged 16 commits into
RedHatInsights:main
from
arburka:add-convert-quickstart
Apr 25, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d278254
added new convert qs
arburka 6ef2109
updated text to say conversion vs preconversion
arburka 2d99d59
Merge branch 'RedHatInsights:main' into add-convert-quickstart
arburka ea08d70
minor text updates to both preconversion and conversion QS to align w…
arburka 72a3450
edits and added pre-upgrade QS
arburka e442579
Merge branch 'RedHatInsights:main' into add-convert-quickstart
arburka 947a89d
Updated metadata tag to match the quickstart name
arburka cd3f540
Merge branch 'main' into add-convert-quickstart
arburka 90059db
Merge branch 'RedHatInsights:main' into add-convert-quickstart
arburka 963013f
updates from content review
arburka e1b13c7
Merge branch 'RedHatInsights:main' into add-convert-quickstart
arburka 8b423dc
Merge branch 'RedHatInsights:main' into add-convert-quickstart
arburka 28b9b07
edits and added pre-upgrade QS
arburka e81473b
Updated metadata tag to match the quickstart name
arburka 2889c86
updates from content review
arburka b58f816
incorporated addtional updates based on feedback
arburka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...tarts/insights-tasks-convert/metadata.yml → ...ts/insights-tasks-conversion/metadata.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we double-check if the names of pre-conversion, conversion and LEAPP quick-starts are the same as outlined in https://issues.redhat.com/browse/RHINENG-7706?focusedId=24329052&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-24329052? I am a bit confused why we are renaming it here to "insights-tasks-conversion" instead of "conversion-quickstart"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkarat I think this comes from the conventions we use in the repo to make it easier for content creators to find files - ie. we start file names with the bundle name (insights-quickstartname). Would it be possible to name the quick start using that convention? It's not a dealbreaker, but would help others to maintain this naming pattern in https://github.com/RedHatInsights/quickstarts/tree/main/docs/quickstarts . Just saw the conversation on your Jira now...