Add convert quickstart #185
Conversation
|
Can one of the admins verify this patch? |
|
/ok-to-test |
| @@ -1,6 +1,6 @@ | |||
| # Additional info: https://docs.openshift.com/container-platform/4.9/web_console/creating-quick-start-tutorials.html | |||
| metadata: | |||
| name: insights-tasks-convert | |||
| name: insights-tasks-conversion | |||
There was a problem hiding this comment.
Can we double-check if the names of pre-conversion, conversion and LEAPP quick-starts are the same as outlined in https://issues.redhat.com/browse/RHINENG-7706?focusedId=24329052&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-24329052? I am a bit confused why we are renaming it here to "insights-tasks-conversion" instead of "conversion-quickstart"
There was a problem hiding this comment.
@gkarat I think this comes from the conventions we use in the repo to make it easier for content creators to find files - ie. we start file names with the bundle name (insights-quickstartname). Would it be possible to name the quick start using that convention? It's not a dealbreaker, but would help others to maintain this naming pattern in https://github.com/RedHatInsights/quickstarts/tree/main/docs/quickstarts . Just saw the conversation on your Jira now...
docs/quickstarts/insights-tasks-conversion/insights-tasks-conversion.yml
Outdated
Show resolved
Hide resolved
|
@Hyperkid123 I think we are ready to merge based on the reviews |
Updated text based on content review
updated metadata names