-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE validation for supply product #378
Merged
marlena-b
merged 2 commits into
RailsEventStore:master
from
marlena-b:be-validation-for-supply-product
Aug 19, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
require "test_helper" | ||
|
||
class SuppliesTest < InMemoryRESIntegrationTestCase | ||
def test_happy_path | ||
product_id = register_product("Async Remote", 100, 10) | ||
|
||
get "/products/#{product_id}/supplies/new" | ||
assert_select "h1", "Supply" | ||
post "/products/#{product_id}/supplies", | ||
params: { | ||
"authenticity_token" => "[FILTERED]", | ||
"product_id" => product_id, | ||
"quantity" => "1" | ||
} | ||
follow_redirect! | ||
|
||
assert_select "#notice", "Stock level changed" | ||
end | ||
|
||
def test_renders_validation_error_when_quantity_is_not_present | ||
product_id = register_product("Async Remote", 100, 10) | ||
|
||
get "/products/#{product_id}/supplies/new" | ||
assert_select "h1", "Supply" | ||
post "/products/#{product_id}/supplies", | ||
params: { | ||
"authenticity_token" => "[FILTERED]", | ||
"product_id" => product_id, | ||
"quantity" => "" | ||
} | ||
|
||
assert_response :unprocessable_entity | ||
assert_select "span", "Quantity can't be blank" | ||
end | ||
|
||
def test_renders_validation_error_when_quantity_is_not_a_number | ||
product_id = register_product("Async Remote", 100, 10) | ||
|
||
get "/products/#{product_id}/supplies/new" | ||
assert_select "h1", "Supply" | ||
post "/products/#{product_id}/supplies", | ||
params: { | ||
"authenticity_token" => "[FILTERED]", | ||
"product_id" => product_id, | ||
"quantity" => "not a number" | ||
} | ||
|
||
assert_response :unprocessable_entity | ||
assert_select "span", "Quantity is not a number" | ||
end | ||
|
||
def test_renders_validation_error_when_quantity_is_zero | ||
product_id = register_product("Async Remote", 100, 10) | ||
|
||
get "/products/#{product_id}/supplies/new" | ||
assert_select "h1", "Supply" | ||
post "/products/#{product_id}/supplies", | ||
params: { | ||
"authenticity_token" => "[FILTERED]", | ||
"product_id" => product_id, | ||
"quantity" => "0" | ||
} | ||
|
||
assert_response :unprocessable_entity | ||
assert_select "span", "Quantity must be greater than 0" | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't use
ActiveModel::Attributes
like in other places because thenonly_integer: true
does not work as expected. It seems likeActiveModel::Attributes
converts the value to integer during the initialization of the object. This is problematic because"abc".to_i # => 0
, so the validation error was "Quantity must be greater than 0" instead of "Quantity is not a number".