BE validation for supply product #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for ecommerce-events failed.
|
marlena-b
commented
Aug 14, 2024
Comment on lines
+3
to
+11
| include ActiveModel::Model | ||
| include ActiveModel::Validations | ||
|
|
||
| attr_reader :product_id, :quantity | ||
|
|
||
| def initialize(params) | ||
| @product_id = params[:product_id] | ||
| @quantity = params[:quantity] | ||
| end |
There was a problem hiding this comment.
I didn't use ActiveModel::Attributes like in other places because then only_integer: true does not work as expected. It seems like ActiveModel::Attributes converts the value to integer during the initialization of the object. This is problematic because "abc".to_i # => 0, so the validation error was "Quantity must be greater than 0" instead of "Quantity is not a number".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #373
This PR adds BE validations for supply product form. This validations checks if the quantity is integer greater than 0 and if not, the proper validation error is rendered.
