[radar-output] Allow config of scan intervals (needed for e2e testing) #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
pvannierop
force-pushed
the
feature/output-restructure-delays
branch
2 times, most recently
from
2f31e99 to
0e1e89e
Compare
keyvaann
reviewed
Dec 18, 2024
| @@ -43,6 +43,13 @@ data: | |||
| {{- if .azure.readTimeout }} | |||
| readTimeout: {{ .azure.readTimeout | int }} | |||
| {{- end }} | |||
| index: | |||
| {{- if .index.fullSyncInterval }} | |||
There was a problem hiding this comment.
Why the if statement if we already have a default value for this?
If both ifs are off, then the chart will be invalid since there will be an empty index: key.
There was a problem hiding this comment.
Ok, I removed the if statements
pvannierop
force-pushed
the
feature/output-restructure-delays
branch
from
0e1e89e to
2a87d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title