Improve language

[andrewdavidwong]

Closes QubesOS/qubes-issues#8057

[andrewdavidwong]

@marmarta, @marmarek: I see that the current content links to https://github.com/Qubes-Community/Contents/blob/master/docs/common-tasks/opening-urls-in-vms.md several times. I think it's a bad idea to link to unofficial documentation from inside of Qubes OS and that we should basically never do this. Do we need to move this piece of documentation into the official docs, or can I simply drop the links to it?

(CCing @taradiddles, the primary editor of that file.)

[andrewdavidwong]

@marmarta: On a separate note, can we change "VM" to "qube" in the file manager actions, per QubesOS/qubes-issues#1015?

• Copy To Other AppVM... -> Copy to other qube...
• Move To Other AppVM... -> Move to other qube...
• Edit In DisposableVM -> Edit in disposable
• View In DisposableVM -> View in disposable

If so, then I can also edit the mentions of them in this file to match (what will be) the new names.

(As you can see, I also suggest changing from capitalizing every word to sentence case, but you can drop this part if you insist on keeping the former.)

[andrewdavidwong]

I reviewed the failed CI test result, but I'm not sure how to interpret it. If there's anything I need to fix, please let me know.

[marmarta]

@marmarta, @marmarek: I see that the current content links to https://github.com/Qubes-Community/Contents/blob/master/docs/common-tasks/opening-urls-in-vms.md several times. I think it's a bad idea to link to unofficial documentation from inside of Qubes OS and that we should basically never do this. Do we need to move this piece of documentation into the official docs, or can I simply drop the links to it?

(CCing @taradiddles, the primary editor of that file.)

I vote to move it to official docs. I think this documentation is pretty useful, and hard to find if you don't know what to look for.

[marmarta]

@marmarta: On a separate note, can we change "VM" to "qube" in the file manager actions, per QubesOS/qubes-issues#1015?

Good idea, I've done it in QubesOS/qubes-core-agent-linux#420

[marmarta]

The test error is related to my comment above: all labels that have links need to be added to the _handle_urls function in global_config.py, and conversely, the labels you removed need to be removed from the list there. I can fix that function once you finalize this PR too.

[andrewdavidwong]

@marmarta, @marmarek: I see that the current content links to https://github.com/Qubes-Community/Contents/blob/master/docs/common-tasks/opening-urls-in-vms.md several times. I think it's a bad idea to link to unofficial documentation from inside of Qubes OS and that we should basically never do this. Do we need to move this piece of documentation into the official docs, or can I simply drop the links to it?
(CCing @taradiddles, the primary editor of that file.)

I vote to move it to official docs. I think this documentation is pretty useful, and hard to find if you don't know what to look for.

I thought of a third option: Leave the doc where it is (in the community doc repo), but add a warning (somewhere) informing the user that it's an unofficial website. Does this seem better? Worse?

Edit: Probably worse. See discussion on QubesOS/qubes-issues#8166.

[codecov]

Codecov Report

Merging #150 (9f73cc5) into main (6857dbe) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 9f73cc5 differs from pull request most recent head 4be2f53. Consider uploading reports for the commit 4be2f53 to get more accurate results

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   95.90%   96.02%   +0.12%     
==========================================
  Files          43       43              
  Lines        8197     8177      -20     
==========================================
- Hits         7861     7852       -9     
+ Misses        336      325      -11     

Impacted Files	Coverage Δ
qubes_config/global_config/global_config.py	86.95% <100.00%> (-0.38%)	⬇️

... and 3 files with indirect coverage changes

[marmarta]

That's not precisely true - you only need to restart the affected qubes, not the whole system. So this can be a bit misleading?

[andrewdavidwong]

But the settings in this section are global. The user doesn't get to choose any individual qubes in this section, so what are "the affected qubes"?

[marmarta]

I'm not a fan of saying those are "English characters", because English does have a bunch of rare, but still existent, letters with diacritics (I've seen it in some places in words like naïve, Charlotte Brontë etc.) - but if you think that ASCII is not understandable enough, we can use this phrasing.

[andrewdavidwong]

But it doesn't say that any characters are "English characters." It just says that if you want to be able to see non-English characters, then the "allow" setting will do that (at the cost of increased attack surface).

This is just intended as a way to anticipate the common question, "How can I get window titles to display in <my_language>?"

[marmarta]

I think this is basically ready to merge? The test fails are not this PR's fault. Anyway it's a "changes approved" from me.

[andrewdavidwong]

I think this is basically ready to merge? The test fails are not this PR's fault. Anyway it's a "changes approved" from me.

Okay, thanks! Ready to go from my side too. :)