Fix usb qube #153
Merged
Fix usb qube #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This got conflicts |
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 96.02% 95.91% -0.12%
==========================================
Files 43 43
Lines 8177 8266 +89
==========================================
+ Hits 7852 7928 +76
- Misses 325 338 +13
|
marmarek
requested changes
May 24, 2023
| while sys_usb not in usb_qube_candidates and policy_candidates: | ||
| try: | ||
| sys_usb = policy_candidates.pop() | ||
| except KeyError: |
There was a problem hiding this comment.
The loop condition guarantee it won't fail this way here, no? Was it meant to handle different case, like running out of policy_candidates before finding any match?
Treat USB qubes as separate things relevant to each policy part. Allow user to have multiple or no usb qubes. Related tests also improved and added.
marmarek
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix usb qube handling in Global Config. Based on #150 to avoid hell of merging glade files.