chore: gas optimizations on terabethia contract #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once
simpleStorage().messages[msgHash]
is assigned to 1. Consider settingsimpleStorage().messages[msgHash]
to zero to show the message has been consumed on the L2.-Gas optimizations within sendMessage function w/ ~500 gas savings in total:
--cache
simpleStorage().nonce
to avoid performing multiple SLOADS--use unchecked math when incrementing
simpleStorage().nonce
, overflow unrealistic. if this contract were called 100 trillion times a day for 100 years we would still not be close to overflow. overflow can and should be monitored outside of the contract.--don't increment
simpleStorage().messages[msgHash]
. instead, assign to 1 to save gas. There's never a situation where this value is anything other than 1 or 0 because the nonce is used when encoding the message hash. The message hash will never be repeated.