Chore/improve eth contracts #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0xtch
reviewed
Nov 2, 2022
| @@ -67,27 +67,26 @@ contract Terabethia is Initializable, ITerabethiaCore { | |||
| external | |||
| returns (bytes32) | |||
| { | |||
| simpleStorage().nonce += 1; | |||
There was a problem hiding this comment.
There is a PR open for this change already #27
There was a problem hiding this comment.
Yes, Its the fist commit of this branch I used it as base
b0xtch
reviewed
Nov 2, 2022
| @@ -27,19 +35,14 @@ contract EthProxy { | |||
| terabethiaCore.consumeMessage(CANISTER_ADDRESS, payload); | |||
|
|
|||
| // withdraw eth | |||
| require( | |||
There was a problem hiding this comment.
Any reason this condition was removed?
There was a problem hiding this comment.
Yes, cause it is useless, its gonna fail anyways
b0xtch
reviewed
Nov 2, 2022
| @@ -61,4 +64,27 @@ contract EthProxy { | |||
| // Send the message to the IC | |||
| terabethiaCore.sendMessage(CANISTER_ADDRESS, payload); | |||
| } | |||
|
|
|||
| function send(address recipient, uint256 amount) | |||
There was a problem hiding this comment.
What is this function for? Also does just give arbitrary ownership of all funds in the contract to the owner?
|
can we merge this? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ETH Proxy:
ERC20 Proxy