Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NCAR branding and source images more consistently #13
Remove NCAR branding and source images more consistently #13
Changes from 1 commit
1f489a2
c1496c8
48576d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what would be the best way to handle contributors' list for the Pythia cookbooks for the cookbooks that are adapted from previous materials. This might include my profile twice (but I am okay with that and no need to change) ;-)
@jsignell An alternative will be to add your profiles individually or point to a repo that you are the only contributor too. Please see above for how I included Ben...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point. I kind of like the idea of just relying on the contributors information on github for this repo. I'm not too worried about people showing up twice but eventually if everyone who contributed to the NCAR version has also contributed over here, then we can just have the one contributor list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsignell for your response. In that case, I will leave this as is.
Overall, this is a bigger issue for the project Pythia maintainers on how to handle the list of contributors for many projects like this, where the cookbooks are adapted from other projects and are collected here as a resource for the community....
Maybe a good topic for future Pythia hackathons...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just remembered that there is an authors section as well where there are links to specific individuals, so maybe it already is ok to just rely on github for the list of contributors?