Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NCAR branding and source images more consistently #13

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

jsignell
Copy link
Member

This PR

  • removes NCAR branding
  • changes references to source canonical images directly from the dask docs and tutorial.
  • deletes unused images

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 650ad08
✅ Deployment Preview URL: https://ProjectPythia.github.io/dask-cookbook/_preview/13

@jsignell
Copy link
Member Author

@negin513 does this look like what you were expecting or do you think it goes too far?

@negin513
Copy link
Collaborator

Sincere apologies @jsignell. I did not get the chance to review this. Please let me review this in the next day or two and I will ping you about this.

@jsignell
Copy link
Member Author

jsignell commented Oct 2, 2023

Ok! I thought it might be helpful to share my timeline on this. The presentation is on October 23rd so I am aiming to be done with the content by Oct 17th - in 2 weeks!! I expect to put up at least 2 or 3 more PRs. I am wondering if there is anything I can do to make the merge process easier. Here are some options:

  1. I am happy to do a synchronous review - just throw a meeting on my calendar
  2. If you are comfortable giving me write access then I can merge my own PRs (in a designated branch if you prefer).

I know that either of these require time and effort on your part and I really appreciate it!

README.md Show resolved Hide resolved
@@ -25,17 +23,21 @@ The motivation behind this repository is to provide a clear and concise resource
<a href="https://github.com/benkirk/demo_containers/graphs/contributors">
<img src="https://contrib.rocks/image?repo=benkirk/demo_containers" />
</a>
<a href="https://github.com/ProjectPythia/dask-cookbook/graphs/contributors">
<img src="https://contrib.rocks/image?repo=ProjectPythia/dask-cookbook" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what would be the best way to handle contributors' list for the Pythia cookbooks for the cookbooks that are adapted from previous materials. This might include my profile twice (but I am okay with that and no need to change) ;-)

@jsignell An alternative will be to add your profiles individually or point to a repo that you are the only contributor too. Please see above for how I included Ben...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good point. I kind of like the idea of just relying on the contributors information on github for this repo. I'm not too worried about people showing up twice but eventually if everyone who contributed to the NCAR version has also contributed over here, then we can just have the one contributor list.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsignell for your response. In that case, I will leave this as is.
Overall, this is a bigger issue for the project Pythia maintainers on how to handle the list of contributors for many projects like this, where the cookbooks are adapted from other projects and are collected here as a resource for the community....

Maybe a good topic for future Pythia hackathons...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just remembered that there is an authors section as well where there are links to specific individuals, so maybe it already is ok to just rely on github for the list of contributors?

@negin513
Copy link
Collaborator

negin513 commented Oct 3, 2023

Hey @jsignell ,

Everything looks good in this notebook and I had a minor comment. For some reason, I noticed in the Xarray + Dask notebook, there are some differences from the previous versions (possibly due to an update in versions of Dask, Xarray maybe?)

See the tref.chunks output cell from the preview and the published version.

Any idea what might be causing this?

@jsignell
Copy link
Member Author

jsignell commented Oct 3, 2023

See the tref.chunks output cell from the preview and the published version.

Oh yikes! Let me see if I can figure that out.

@negin513
Copy link
Collaborator

negin513 commented Oct 4, 2023

I talked with @jsignell and got a confirmation that the chunking stuff will be updated in future prs. So I merging this in. Thanks @jsignell .

@negin513 negin513 merged commit f5011b0 into ProjectPythia:main Oct 4, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
@jsignell jsignell deleted the remove-ncar-branding branch October 4, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants