feat(request): temperature en enum et pas en integer

app/controllers/api/v1/users_controller.rb

@@ -29,7 +29,7 @@ def destroy
     user = policy_scope(User).kept.find(params[:id])
     authorize user
 
-    if current_user.discard
+    if user.discard
       head :no_content
     else
       render_validation_error(user)

app/models/request.rb

@@ -7,6 +7,11 @@ class Request < ApplicationRecord
             in: %i[pending accepted refused in_cancelation canceled completed],
             default: :pending
 
+  enumerize :temperature,
+            in: %i[Chaud Froid Extérieur Autre],
+            predicates: true,
+            scope: true
+
   # Validations
   validates :name,
             :status,
@@ -85,7 +90,7 @@ class Request < ApplicationRecord
 #  comment              :text
 #  due_date             :date
 #  quantity             :integer
-#  temperature          :integer
+#  temperature          :string
 #  photoperiod          :integer
 #  created_at           :datetime         not null
 #  updated_at           :datetime         not null
@@ -99,3 +104,4 @@ class Request < ApplicationRecord
 #  index_requests_on_handler_id      (handler_id)
 #  index_requests_on_plant_stage_id  (plant_stage_id)
 #
+#

config/routes.rb

@@ -11,11 +11,6 @@
 
       resource :passwords, only: :update
 
-      resources :account_requests, only: %i[index show create destroy] do
-        get :pending_account_requests_count, on: :collection
-        post :accept, on: :member
-      end
-
       resources :users, only: %i[index show create destroy]
 
       resources :pots, only: %i[index show create update destroy]

db/migrate/20241217142757_change_temperature_to_enum_in_requests.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class ChangeTemperatureToEnumInRequests < ActiveRecord::Migration[7.2]
+  def up
+    change_column :requests, :temperature, :string
+  end
+
+  def down
+    change_column :requests, :temperature, :integer
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.2].define(version: 2024_12_17_133422) do
+ActiveRecord::Schema[7.2].define(version: 2024_12_17_142757) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
@@ -135,7 +135,7 @@
     t.text "comment"
     t.date "due_date"
     t.integer "quantity"
-    t.integer "temperature"
+    t.string "temperature"
     t.integer "photoperiod"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false

db/seeds.rb

@@ -138,7 +138,7 @@
     comment: Faker::Movies::LordOfTheRings.quote,
     due_date: Date.current + 3.months,
     quantity: 50,
-    temperature: 20,
+    temperature: 'Chaud',
     photoperiod: 8
   )
 

spec/acceptance/api/v1/requests_controller_spec.rb

@@ -122,7 +122,7 @@
     let(:due_date)       { Date.current + 6.months }
     let(:quantity)       { 150 }
     let(:comment)        { 'The specimens have to be in perfect condition, please be careful!' }
-    let(:temperature)    { 35 }
+    let(:temperature)    { 'Froid' }
     let(:photoperiod)    { 12 }
     let(:requester_first_name) { 'John' }
     let(:requester_last_name)  { 'Doe' }

spec/requests/api/v1/requests_spec.rb

@@ -124,7 +124,7 @@
               quantity: 150,
               due_date: Date.current + 6.months,
               comment: 'My comment',
-              temperature: 10,
+              temperature: 'Chaud',
               photoperiod: 4,
               requester_first_name: 'John',
               requester_last_name: 'Doe',
@@ -144,7 +144,7 @@
           expect(request.quantity).to eq(150)
           expect(request.due_date).to eq(Date.current + 6.months)
           expect(request.comment).to eq('My comment')
-          expect(request.temperature).to eq(10)
+          expect(request.temperature).to eq('Chaud')
           expect(request.photoperiod).to eq(4)
           expect(request.requester_first_name).to eq('John')
           expect(request.requester_last_name).to eq('Doe')
@@ -162,7 +162,7 @@
               quantity: 150,
               due_date: Date.current + 6.months,
               comment: 'My comment',
-              temperature: 10,
+              temperature: 'Chaud',
               photoperiod: 4,
               requester_first_name: 'John',
               requester_last_name: 'Doe',
@@ -183,7 +183,7 @@
           expect(request.quantity).to eq(150)
           expect(request.due_date).to eq(Date.current + 6.months)
           expect(request.comment).to eq('My comment')
-          expect(request.temperature).to eq(10)
+          expect(request.temperature).to eq('Chaud')
           expect(request.photoperiod).to eq(4)
           expect(request.requester_first_name).to eq('John')
           expect(request.requester_last_name).to eq('Doe')
@@ -205,7 +205,7 @@
               quantity: 150,
               due_date: Date.current + 6.months,
               comment: 'My comment',
-              temperature: 10,
+              temperature: 'Chaud',
               photoperiod: 4,
               requester_first_name: 'John',
               requester_last_name: 'Doe',
@@ -227,7 +227,7 @@
           expect(request.quantity).to eq(150)
           expect(request.due_date).to eq(Date.current + 6.months)
           expect(request.comment).to eq('My comment')
-          expect(request.temperature).to eq(10)
+          expect(request.temperature).to eq('Chaud')
           expect(request.photoperiod).to eq(4)
           expect(request.requester_first_name).to eq('John')
           expect(request.requester_last_name).to eq('Doe')
@@ -245,7 +245,7 @@
               quantity: 150,
               due_date: Date.current + 6.months,
               comment: 'My comment',
-              temperature: 10,
+              temperature: 'Chaud',
               photoperiod: 4,
               requester_first_name: 'John',
               requester_last_name: 'Doe',
@@ -267,7 +267,7 @@
           expect(request.quantity).to eq(150)
           expect(request.due_date).to eq(Date.current + 6.months)
           expect(request.comment).to eq('My comment')
-          expect(request.temperature).to eq(10)
+          expect(request.temperature).to eq('Chaud')
           expect(request.photoperiod).to eq(4)
           expect(request.requester_first_name).to eq('John')
           expect(request.requester_last_name).to eq('Doe')

test/fixtures/requests.yml

@@ -14,7 +14,7 @@ request1:
   comment: I didn't think it would end this way.
   due_date: 2020-05-13
   quantity: 100
-  temperature: 20
+  temperature: "Chaud"
   photoperiod: 8
   created_at: !ruby/object:ActiveSupport::TimeWithZone
     utc: &1 2020-02-13 00:04:08.434029000 Z
@@ -67,7 +67,7 @@ request2:
 #  comment              :text
 #  due_date             :date
 #  quantity             :integer
-#  temperature          :integer
+#  temperature          :string
 #  photoperiod          :integer
 #  created_at           :datetime         not null
 #  updated_at           :datetime         not null

test/models/request_test.rb

@@ -105,6 +105,12 @@ def setup
     assert_not_empty @request.errors[:status]
   end
 
+  test 'invalid with incorrect temperature value' do
+    @request.temperature = 'foo'
+    assert_not @request.valid?
+    assert_not_empty @request.errors[:temperature]
+  end
+
   # State Machine
   test 'can\'t be accepted without at least one request distribution' do
     @request.request_distributions = []
@@ -133,7 +139,7 @@ def setup
 #  comment              :text
 #  due_date             :date
 #  quantity             :integer
-#  temperature          :integer
+#  temperature          :string
 #  photoperiod          :integer
 #  created_at           :datetime         not null
 #  updated_at           :datetime         not null