feat(request): temperature en enum et pas en integer #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterOryon
reviewed
Dec 18, 2024
|
Tao-Galasse
reviewed
Dec 19, 2024
| @@ -29,7 +29,7 @@ def destroy | |||
| user = policy_scope(User).kept.find(params[:id]) | |||
| authorize user | |||
|
|
|||
| if current_user.discard | |||
| if user.discard | |||
There was a problem hiding this comment.
ah, je vois que ma remarque sur la précédente PR a déjà été détecté et corrigé, bien joué :)
| @@ -7,6 +7,11 @@ class Request < ApplicationRecord | |||
| in: %i[pending accepted refused in_cancelation canceled completed], | |||
| default: :pending | |||
|
|
|||
| enumerize :temperature, | |||
| in: %i[Chaud Froid Extérieur Autre], | |||
There was a problem hiding this comment.
en général, on va préférer que les enums soient en anglais et en minuscule dans le code, et avoir les clés de traductions dans côté front et éventuellement côté back (cf le fichier enumerize.fr.yml)
Suggested change
| in: %i[Chaud Froid Extérieur Autre], | |
| in: %i[hot cold outside other], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.