Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC7 WD Thermal Control Patch #197

Merged
merged 40 commits into from
Jan 11, 2023

Conversation

zCoCo
Copy link
Member

@zCoCo zCoCo commented Jan 11, 2023

Code uploaded to WD during RC7 (only WD code was uploaded).

  • Largely closes Fix Battery Thermistor Data & Heater Control #196 .
    • Heater controller now comes on at 85% duty (instead of 0).
    • Correct thermal readings are used in the correct places.
    • Added (potentially dangerous) ability to switch to using charging thermistor instead of battery thermistor for heater control if needed.
    • Debounced heater controller.
    • Validated heater control scheme.
    • Added and validated all (still used) thermistor and heater WD commands.
    • Corrected the thermistor telem sent from WD to Herc.
    • Added ability to override heater control and force heater to be on or off.
  • Corrects thermistor conversions in GSW for WD (validated to be quite accurate at ~STP).
  • Adds command aliases to GDS for changing heater control settings.
  • Added thermistor failure detection to heater controller so, if heater breaks during flight LOS, heater will just kick on and stay on (but can be turned back off if desired).
  • Added ResetSpecific ACK response packets that add more details about what happened (useful for verifying heater commands went through and not just some reset specific).
  • Calibrated voltage ADC readings.
  • ReportStatus prompts a DetailedStatus and FlightHeartbeat to be downlinked (since Batt_RT temp is only correct in the heartbeat - see known bugs).
  • Updated DetailedStatusPacket prints in GDS to highlight relevant information and hide deprecated fields.
  • Corrected WD heater on/off thresholds to be -5C and +5C respectively.
  • Performed testing on FM1 to validate flight temperature conversions, thermistor connection, heater connection, and heater duty cycle control.

Known Bugs:

  • Batt_RT readings are wrong in DetailedStatus packet (always 1) but correct in FlightHeartbeat.
  • Heater settings are NOT persistent as of RC7.

RC7 will include diagram of how built heater controller works and docs of which commands and settings are still active and which are deprecated + commands needed for certain ops.

zCoCo and others added 30 commits December 30, 2022 14:23
… (RT) instead of charging thermistor (battTemp).
…rom 0%) so heater control can actually control the heater.
…anetaryRobotics/CubeRoverPackage into cwcolomb/196-wd-thermal-control-patch
@zCoCo zCoCo added enhancement New feature or request _CRITICAL Very important. Need this working ASAP. GSW-GDS Ground Data System int-test Integrated System Test Required bug-impactful Bug with the potential to degrade mission objectives. labels Jan 11, 2023
@zCoCo zCoCo added this to the RC7 milestone Jan 11, 2023
@zCoCo zCoCo self-assigned this Jan 11, 2023
@zCoCo zCoCo linked an issue Jan 11, 2023 that may be closed by this pull request
12 tasks
@zCoCo zCoCo merged commit edb904b into release-candidate Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-impactful Bug with the potential to degrade mission objectives. _CRITICAL Very important. Need this working ASAP. enhancement New feature or request GSW-GDS Ground Data System int-test Integrated System Test Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Battery Thermistor Data & Heater Control
2 participants