Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pages translatable #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make pages translatable #586

wants to merge 2 commits into from

Conversation

jean
Copy link
Contributor

@jean jean commented Feb 9, 2020

No description provided.

@talha131
Copy link
Member

talha131 commented Feb 9, 2020

@jean thanks a lot for your contribution.

Can you please add an example of this translation feature working to your PR? I would really appreciate it.

@talha131 talha131 self-assigned this Feb 9, 2020
@jean
Copy link
Contributor Author

jean commented Feb 9, 2020

Can you please add an example of this translation feature working to your PR?

It should basically work as documented in the Pelican docs. Does that count as example enough?

Actually, while looking into that, I noticed that the default Pelican themes include <link rel="alternate" hreflang="en" href="..."> in the head section. It looks like that was introduced in a PR from 2018: https://github.com/getpelican/pelican/pull/2374/files#diff-874ea5927c0a7c40c08b57203c5e304dR10
I added that to my PR as well.

@talha131
Copy link
Member

I added that to my PR as well.

Thank your for that. I never would have known.

It should basically work as documented in the Pelican docs. Does that count as example enough?

If you can add two sample articles to the doc that would be enough. You can copy example from the Pelican site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants