Add translation support #26

jean · 2020-02-09T03:15:10Z

No description provided.

Can't mix translated and un-translated pages

georgically

Looks great overall except a few points I've commented. : )

georgically · 2020-02-10T08:47:47Z

content/pages/about-en.md

 ---


 # About

 PyCon Thailand is a community effort driven by the members of the Python Community in Bangkok and the entire organising team are all volunteers. PyCon thailand is run as a Non-profit event and any money made from ticket sales or sponsorship is put back into this or future events to grow the community.

-PyCon Thailand sets itself apart from other many other developer events in Thailand by being both non-profit and by having an affordable ticket price. The event can be a professional conference that provides valuable training and networking to companies. PyCon Thailand also provides financial support to the non-professional Python community of Thailand.
+PyCon Thailand sets itself apart from other many other developer events in Thailand by being both non-profit and by having an affordable ticket price. The event can be a professional conference that provides valuable training and networking to companies. Pycon Thailand also provides financial support to non-professinal Python community of Thailand.


PyCon Thailand also provides financial support to the non-professional Python community of Thailand.

Pycon ("c"needs to be captalized)

the word "the"should not be deleted

non-professinal (spelling) corrected

Suggested change

PyCon Thailand sets itself apart from other many other developer events in Thailand by being both non-profit and by having an affordable ticket price. The event can be a professional conference that provides valuable training and networking to companies. Pycon Thailand also provides financial support to non-professinal Python community of Thailand.

PyCon Thailand sets itself apart from many other developer events in Thailand by being both non-profit and by having an affordable ticket price. The event can be a professional conference that provides valuable training and networking to companies. Pycon Thailand also provides financial support to non-professinal Python community of Thailand.

Is that other duplicated?

Augh, please ignore this file, it shouldn't really be in git at all.
The content comes from the Notion page, edit it there.

georgically · 2020-02-10T08:49:33Z

content/pages/about-en.md

 * 2019: will be bigger and better
-* 2018: Sold out event for over 200 attendees. See [Archive](https://2018.th.pycon.org/) and last year's talks on youtube.
+* 2018: Sold out event for over 200 attendees. See Archive and last years talks on youtube.


2018: Sold out event for over 200 attendees. See Archive and 2018's talks on YouTube.

georgically · 2020-02-10T08:50:25Z

content/pages/about-en.md


-* 2020: We will be doubling in size again!
 * 2019: will be bigger and better


2019 : Over 250 tickets sold! Tickets sold out a week before event.

georgically · 2020-02-10T08:52:16Z

pelicanconf.py

@@ -4,14 +4,19 @@

 AUTHOR = 'Tech WG'
 SITENAME = 'PyCon Thailand 2020'
-SITEURL = ''
+SITEURL = 'https://th.pycon.org'


Remove this as it will make using local server impossible. SITEURL is already defined in publishconf for production version.

OK, switching netlify build to use that.

Content comes from Notion. The `about-en.md` page got picked up as a rename of the sample `about.md` page, but it's just confusing.

bluenex

I have several comments on typos and string formatting.

bluenex · 2020-02-11T08:55:33Z

content/pages/about-en.md

+date: 2019-10-04 12:47:00
+summary: 
+slug: about
+lang: en
 ---


 # About

 PyCon Thailand is a community effort driven by the members of the Python Community in Bangkok and the entire organising team are all volunteers. PyCon thailand is run as a Non-profit event and any money made from ticket sales or sponsorship is put back into this or future events to grow the community.


Suggested change

PyCon Thailand is a community effort driven by the members of the Python Community in Bangkok and the entire organising team are all volunteers. PyCon thailand is run as a Non-profit event and any money made from ticket sales or sponsorship is put back into this or future events to grow the community.

PyCon Thailand is a community effort driven by the members of the Python Community in Bangkok and the entire organising team are all volunteers. PyCon Thailand is run as a non-profit event and any money made from ticket sales or sponsorship is put back into this or future events to grow the community.

Thailand (capitalized "T")

non-profit (lowercase "n")

bluenex · 2020-02-11T08:56:54Z

content/pages/about-en.md


-## About Python
+## __*About Python*__


is __* for both italic and bold? As a header, shouldn't only italic be enough?

That's the output of Notion.

bluenex · 2020-02-11T08:59:27Z

content/pages/about-en.md


 * Python is an open source programming language.
 * \#1 learning language in USA universities
 * \#3 most popular developer language in the world
 * Used by organisations such as Google, Wikipedia, CERN, NASA, Facebook, Instagram and Spotify.
 * Popularly used for Web Development, Artificial Intelligence, DevOps, Scientific Research and Data Analytics.
-
-## About PyCon
+## __*About PyCon*__


Shouldn't this header have surrounded space (both on top and bottom)?

bluenex · 2020-02-11T08:59:36Z

content/pages/about-en.md

@@ -28,16 +29,14 @@ PyCon Thailand sets itself apart from other many other developer events in Thail
 * Hosted in 45 different countries.
 * Supported and attended by the world’s top technology organisations.
 * Key topics include Data Analytics, Machine Learning, Science, Robotics, Web Development, DevOps, Internet of Things, Gaming and Databases.
-
-## The People
+## __*The People*__


Shouldn't this header have surrounded space (both on top and bottom)?

bluenex · 2020-02-11T09:00:21Z

content/pages/about-en.md

 * \#1 learning language in USA universities
 * \#3 most popular developer language in the world


Should there be a full stop (".")?

bluenex · 2020-02-11T09:00:40Z

content/pages/about-en.md

 * PyCon (US) One of the top developer conferences
 * Established in 2003


Should there be a full stop?

bluenex · 2020-02-11T09:02:22Z

content/pages/about-en.md

@@ -28,16 +29,14 @@ PyCon Thailand sets itself apart from other many other developer events in Thail
 * Hosted in 45 different countries.
 * Supported and attended by the world’s top technology organisations.
 * Key topics include Data Analytics, Machine Learning, Science, Robotics, Web Development, DevOps, Internet of Things, Gaming and Databases.
-
-## The People
+## __*The People*__

 Pycon attracts people from all over the world. Pycon is one of the largest open source language developer conference in Thailand. In Pycon 2018, 83% attendees are from Thailand and 17% of the international attendees are well represented by South-east Asian countries. Many people traveled from the USA and all over Europe to attend too. This is because Thailand is also a well-known for it's good food, culture and climate. Attendees are entrepreneurs, developers, educators, engineers and young aspiring Python users. What they all have in common is a passion for the programming language, Python. They come to discover, meet people, learn stuff, have fun, and be inspired.


... Thailand is also a well-known for it's good food, ...

"its good food"

bluenex · 2020-02-11T09:22:49Z

get_posts_from_notion.py

+        text = """---
 title: %s
 date: %s
-description: 
+summary: %s
+slug: %s
+lang: %s
 ---
-""" % (post.title, datetime.datetime.now())
-    # Handle Title
-    text = text + '\n\n' + '# ' + post.title + '\n\n'
-    for content in post.children:
-        # Handles H1
-        if content.type == 'header':
-            text = text + '# ' + content.title + '\n\n'
-        # Handles H2
-        elif content.type == 'sub_header':
-            text = text + '## ' + content.title + '\n\n'
-        # Handles H3
-        elif content.type == 'sub_sub_header':
-            text = text + '### ' + content.title + '\n\n'
-        # Handles Code Blocks
-        elif content.type == 'code':
-            text = text + '```\n' + content.title + '\n```\n\n'
-        # Handles Images
-        elif content.type == 'image':
-            text = text + '![' + content.id + '](' + content.source + ')\n\n'
-        # Handles Bullets
-        elif content.type == 'bulleted_list':
-            text = text + '* ' + content.title + '\n'
-        # Handles Dividers
-        elif content.type == 'divider':
-            text = text + '---' + '\n\n'
-        # Handles Basic Text, Links, Single Line Code
-        elif content.type == 'text':
-            text = text + content.title + '\n\n'
-        else:
-            print("Ignoring unknown block", content)
+""" % (page.title, page.created, page.summary, page.slug, page.language)


This can be fstring too if you like. IMO, it would be a bit cleaner as there is no chain anymore.

It looks like Netlify only supports 3.6 which doesn't have fstrings yet.

From PEP 498, the fstring is working since 3.6 isn't it?

All I know is that it blew up when I pushed it ... I might have fumbled something.

Hmm... what's the status of this now by the way?

jean · 2020-02-11T11:21:47Z

By the way, this work prompted a PR upstream: Pelican-Elegant/elegant#586

jean added 8 commits February 9, 2020 10:14

Add translation support

08c5539

Switch to Python 3.6 for f-string support

2de9e82

No Python 3.6 on Netlify? Switch back to %-interpolation

3d201c7

Split posts/pages; fix support for translation

578c370

Fix page indentation

d3097f3

Log less

ee90d18

Fix default content

6e6d677

Can't mix translated and un-translated pages

Make pages translatable

306b4d2

jean requested review from bluenex and georgically February 9, 2020 06:21

jean self-assigned this Feb 9, 2020

Add language names, in addition to the codes

209b63f

georgically requested changes Feb 10, 2020

View reviewed changes

jean added 3 commits February 11, 2020 16:14

make publish to use publishconf.py on netlify

5ebefdf

The about.md page was just a sample, delete it

5038564

Content comes from Notion. The `about-en.md` page got picked up as a rename of the sample `about.md` page, but it's just confusing.

Netlify will make publish which uses publishconf.py

0c924d4

bluenex reviewed Feb 11, 2020

View reviewed changes

jean merged commit d7bdadb into PyConTH:master Feb 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add translation support #26

Add translation support #26

jean commented Feb 9, 2020

georgically left a comment

georgically Feb 10, 2020

bluenex Feb 11, 2020

jean Feb 11, 2020

georgically Feb 10, 2020

georgically Feb 10, 2020

georgically Feb 10, 2020

jean Feb 11, 2020

bluenex left a comment

bluenex Feb 11, 2020

bluenex Feb 11, 2020

jean Feb 11, 2020

bluenex Feb 11, 2020

bluenex Feb 11, 2020

bluenex Feb 11, 2020

bluenex Feb 11, 2020

bluenex Feb 11, 2020

bluenex Feb 11, 2020

jean Feb 11, 2020 •

edited

Loading

bluenex Feb 12, 2020

jean Feb 12, 2020

georgically Feb 25, 2020

jean commented Feb 11, 2020

	PyCon Thailand sets itself apart from other many other developer events in Thailand by being both non-profit and by having an affordable ticket price. The event can be a professional conference that provides valuable training and networking to companies. Pycon Thailand also provides financial support to non-professinal Python community of Thailand.
	PyCon Thailand sets itself apart from many other developer events in Thailand by being both non-profit and by having an affordable ticket price. The event can be a professional conference that provides valuable training and networking to companies. Pycon Thailand also provides financial support to non-professinal Python community of Thailand.


		* 2020: We will be doubling in size again!
		* 2019: will be bigger and better

	PyCon Thailand is a community effort driven by the members of the Python Community in Bangkok and the entire organising team are all volunteers. PyCon thailand is run as a Non-profit event and any money made from ticket sales or sponsorship is put back into this or future events to grow the community.
	PyCon Thailand is a community effort driven by the members of the Python Community in Bangkok and the entire organising team are all volunteers. PyCon Thailand is run as a non-profit event and any money made from ticket sales or sponsorship is put back into this or future events to grow the community.

		* \#1 learning language in USA universities
		* \#3 most popular developer language in the world

		* PyCon (US) One of the top developer conferences
		* Established in 2003

Add translation support #26

Add translation support #26

Conversation

jean commented Feb 9, 2020

georgically left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bluenex left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jean Feb 11, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jean commented Feb 11, 2020

jean Feb 11, 2020 •

edited

Loading