Bookdown conversion #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn R project. Modified .gitignore accordingly. Modified r_dplyr_package.md so R code is not evaluated. Removed soon-to-be outdated deployment location information from README.md.
…erences to figures to work with bookdown. Normalized section hierarchy.
…rk with bookdown. Changed references to "beta" to "v1".
…n a separate window or tab.
…ding updating obsolete vignette link.
dlebauer
approved these changes
Aug 22, 2019
|
Looks great - thank you for doing such a thorough job of migrating the content and updating the links! |
|
@dlebauer to fast on teh merge button, this did not have the .travis.yml file yet. |
This was referenced Aug 23, 2019
Open
|
@dlebauer @robkooper This brings up the question: Is there a way to require more than one reviewer to sign off on a PR? |
|
Not sure you want this, since what if you only add 1 reviewer. I think the trick is next time to have {WIP} in the title. That will prevent it from being merged. Also I'd suggest in the body next time add checkboxes so we can make sure that all boxes are checked before it gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added need files, deleted unneeded ones, and fixed some things in markdown files (mostly links) to work with bookdown.
@robkooper This needs a .travis.yml file.
@dlebauer The image in the SQL queries chapter is out of date in spite of the assertion in paragraph two that "the tables below are stable." The second and third links on the "PEcAn R Package" page are broken, and I didn't know exactly what they should be.