Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pelahi askapingest #405

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Pelahi askapingest #405

wants to merge 37 commits into from

Conversation

pelahi
Copy link
Contributor

@pelahi pelahi commented Oct 19, 2020

This is a new set of cygnets geared towards the askap ingest node running sles12sp5. Currently the python cygnets are stored in a subdirectory python-cygnets to keep cygnets somewhat organised. However, this setup might require alteration since maali by default does not search this directory unless the -k command is passed. For python and r packages are many, thus it might be useful to update maali to search a directory and a few default subdirectories, allowing cygnets to be organised in a more useful fashion.

Copy link
Contributor

@marcodelapierre marcodelapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I just have an observation, related to your description (however the actual files seem to be already OK).

For OS specific cygnet directories, for now I would avoid organising python/r cygnets in subdirectories, just not to change the way maali works. I would defer this for later consideration (if we keep on using maali).

However, as I said, the files in the PR seem all to be in the main directory anyway. :)

Thanks Pascal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants