-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeStyle][CINN] ruff F401 and F403 in python/cinn #55182
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7a3a906
F401
Liyulingyue a8d3645
update imports style
SigureMo a63a4ba
empty commit, re-trigger all ci
SigureMo ff39440
Merge branch 'develop' into ruff4
SigureMo ff64529
empty commit, re-trigger all ci
SigureMo fbfd6be
Update pyproject.toml
Liyulingyue 2307910
Update pyproject.toml
Liyulingyue ce88cbe
empty commit, re-trigger all ci
SigureMo 5277fba
fix F403
SigureMo d15f1c0
add an useless F401 in ir.__init__.py
SigureMo dccfc6e
empty commit, re-trigger all ci
SigureMo 9067078
remove Object from common
SigureMo e852e16
Merge branch 'develop' into ruff4
SigureMo eba3ffb
empty commit, re-trigger all ci
SigureMo 9cfa191
empty commit, re-trigger all ci
SigureMo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,16 +12,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from .core_api.common import * | ||
from .core_api.common import ( | ||
Bool, | ||
CINNValue, | ||
Float, | ||
Int, | ||
String, | ||
Target, | ||
Type, | ||
UInt, | ||
Void, | ||
make_const, | ||
) | ||
from .core_api.common import * # noqa: F401 | ||
from .core_api.common import Bool # noqa: F401 | ||
from .core_api.common import CINNValue # noqa: F401 | ||
from .core_api.common import Float # noqa: F401 | ||
from .core_api.common import Int # noqa: F401 | ||
from .core_api.common import String # noqa: F401 | ||
from .core_api.common import Target # noqa: F401 | ||
from .core_api.common import Type # noqa: F401 | ||
from .core_api.common import UInt # noqa: F401 | ||
from .core_api.common import Void # noqa: F401 | ||
from .core_api.common import make_const # noqa: F401 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这里我记得可以直接这样写: from a import ( # noqa: F401
b,
c,
d,
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行本来也不会报 F401 吧?只会报 F403 吧?
不过没关系,之后要展开这个
*
的,这个 PR 就不要改了