[CodeStyle][CINN] ruff F401 and F403 in python/cinn #55182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
SigureMo
reviewed
Jul 5, 2023
python/cinn/common.py
Outdated
| Void, | ||
| make_const, | ||
| ) | ||
| from .core_api.common import * # noqa: F401 |
There was a problem hiding this comment.
这行本来也不会报 F401 吧？只会报 F403 吧？
不过没关系，之后要展开这个 * 的，这个 PR 就不要改了
python/cinn/common.py
Outdated
| from .core_api.common import Type # noqa: F401 | ||
| from .core_api.common import UInt # noqa: F401 | ||
| from .core_api.common import Void # noqa: F401 | ||
| from .core_api.common import make_const # noqa: F401 |
There was a problem hiding this comment.
这里我记得可以直接这样写：
from a import ( # noqa: F401
b,
c,
d,
)
|
奇了个怪怪，PR-CI-Inference 明明过了但一直 Pending，@Liyulingyue rerun 一下吧 |
|
很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。 |
SigureMo
changed the title
|
@Liyulingyue 麻烦 rerun 下挂掉的 CI |
cqulilujia
pushed a commit
to cqulilujia/Paddle
that referenced
this pull request
Jul 24, 2023
Co-authored-by: SigureMo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
#54953 case 12