Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

fix_issue583_Remove unnecessary null pointer checks #1140

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 6, 2023

fix_issue583_remove_nullpoint: #583
del:
An extra null pointer check is not needed in functions like the following.

Buffer::DeallocHost
Shape::Resize

Copy link

@elfring elfring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Would an other commit message be more helpful?

cinn/runtime/buffer.cc Outdated Show resolved Hide resolved
@luotao1
Copy link
Collaborator

luotao1 commented Jan 6, 2023

Would an other commit message be more helpful?

@elfring What do you mean about an other commit message?

@elfring
Copy link

elfring commented Jan 6, 2023

💭 I suggest to improve commit messages according to known information sources.

Copy link

@elfring elfring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Please provide an improved merge/pull request with consistent changes.

@luotao1
Copy link
Collaborator

luotao1 commented Jan 6, 2023

Please provide an improved merge/pull request with consistent changes.

@enkilee You can update the PR title and improve the PR description.

@elfring
Copy link

elfring commented Jan 6, 2023

🤔 Would you like to take further update candidates into account?

@enkilee enkilee changed the title fix_issue583_remove_nullpoint fix_issue583_Remove unnecessary null pointer checks Jan 6, 2023
@zhhsplendid
Copy link
Member

🤔 Would you like to take further update candidates into account?

Sure, we will try to fix more places like these in the near future. @elfring Thank you for the code improvement suggestion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants