-
Notifications
You must be signed in to change notification settings - Fork 114
fix_issue583_Remove unnecessary null pointer checks #1140
base: develop
Are you sure you want to change the base?
fix_issue583_Remove unnecessary null pointer checks #1140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 Would an other commit message be more helpful?
@elfring What do you mean about an other commit message? |
💭 I suggest to improve commit messages according to known information sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 Please provide an improved merge/pull request with consistent changes.
@enkilee You can update the PR title and improve the PR description. |
🤔 Would you like to take further update candidates into account? |
Sure, we will try to fix more places like these in the near future. @elfring Thank you for the code improvement suggestion. |
fix_issue583_remove_nullpoint: #583
del:
An extra null pointer check is not needed in functions like the following.
Buffer::DeallocHost
Shape::Resize