Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Remove unnecessary null pointer checks #583

Open
elfring opened this issue Nov 16, 2021 · 4 comments
Open

Remove unnecessary null pointer checks #583

elfring opened this issue Nov 16, 2021 · 4 comments
Labels
good first issue Good for newcomers

Comments

@elfring
Copy link

elfring commented Nov 16, 2021

An extra null pointer check is not needed in functions like the following.

@luotao1
Copy link
Collaborator

luotao1 commented Jan 3, 2023

@elfring Thanks very much for this suggestion, you can create a PR to fix it.

@luotao1 luotao1 added the good first issue Good for newcomers label Jan 3, 2023
@enkilee
Copy link
Contributor

enkilee commented Jan 6, 2023

#1140

@elfring
Copy link
Author

elfring commented Jan 6, 2023

@luotao1
Copy link
Collaborator

luotao1 commented Jan 6, 2023

@elfring Yes, we have the plan to use clang-tidy, here is the plan. However we don't have enough people and time to start this plan.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants