-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilities: Provide valid values to .lh-*
#1952
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One point to clarify.
I am at your disposal to talk about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me.
Just one conflict to resolve and it will be ok for lead dev review.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
#1839 could benefit from this.
#1467 could benefit from this.
Description
Provide some understandable values as utilities.
Motivation & Context
Some weird and similar values provided for the
.lh-*
utility. Changing to be clearer, more logical and closer to some basic line-heights provided by the design. (.lh-sm
and.lh-lg
could remain the same?)Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge