Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities: Provide valid values to .lh-* #1952

Merged
merged 5 commits into from
Apr 27, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Apr 6, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#1839 could benefit from this.
#1467 could benefit from this.

Description

Provide some understandable values as utilities.

Motivation & Context

Some weird and similar values provided for the .lh-* utility. Changing to be clearer, more logical and closer to some basic line-heights provided by the design. (.lh-sm and .lh-lg could remain the same?)

Types of change

  • Refactoring (non-breaking change)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 9703a5c
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/644a2776c766ea00082ead02
😎 Deploy Preview https://deploy-preview-1952--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

scss/_utilities.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One point to clarify.
I am at your disposal to talk about it.

Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me.

Just one conflict to resolve and it will be ok for lead dev review.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 79ef8cc into main Apr 27, 2023
@julien-deramond julien-deramond deleted the main-lmp-line-height-utility branch April 27, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants