feat(utilities): change values of .lh-* (#1952)

Orange-OpenSource · Apr 27, 2023 · 79ef8cc · 79ef8cc
1 parent 7db89e0
commit 79ef8cc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/scss/_utilities.scss b/scss/_utilities.scss
@@ -523,14 +523,15 @@ $utilities: map-merge(
         bolder: $font-weight-bolder
       )
     ),
+    // Boosted mod: use hardcoded values instead of variables since our variables can't fit utilities
     "line-height": (
       property: line-height,
       class: lh,
       values: (
         1: 1,
-        sm: $line-height-sm,
-        base: $line-height-base,
-        lg: $line-height-lg,
+        sm: 1.25, // Boosted mod: instead of `$line-height-sm`
+        base: 1.5, // Boosted mod: instead of `$line-height-base`
+        lg: 2, // Boosted mod: instead of `$line-height-lg`
       )
     ),
     "line-length": (

diff --git a/site/content/docs/5.3/migration.md b/site/content/docs/5.3/migration.md
@@ -202,6 +202,8 @@ Learn more by reading the new [color modes documentation]({{< docsref "/customiz
 
 - <span class="badge bg-success">New</span> Added new `.d-inline-grid` [display utility]({{< docsref "/utilities/display" >}}).
 
+- <span class="badge bg-warning">Warning</span> We slightly changed the values for `.lh-sm`, `.lh-base` and `.lh-lg` to provide some more usable values. Please check that it doesn't break your design. Otherwise, it could still be reverted by setting the value directly in `_utilities.scss`.
+
 ### Examples
 
 - **Cards/Cards RTL**