-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example: New e-shop example #1839
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
For instance, I think I won't fix 2, 3 since those will introduce more unusable javascript for projects, 5 because we don't have it now. I'll update the corresponding issue to not forget it. 8, 10 will probably be tackled with dark mode. |
<li class="card border-0 pt-4 pt-md-4"> | ||
<h3 class="visually-hidden">xxxx xxx</h3> | ||
<div class="d-flex mt-md-3 mb-2 align-items-end justify-content-between border-bottom border-danger fw-bold"> | ||
<div class="d-flex mt-md-3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big fan of those .mt-md-3
and mt-xl-3
since they are quite too manual imo. At least we get the same rendering as the design.
Thank you for the latest updates. @louismaximepiton |
@MewenLeHo Could please you finish the review on your side? |
Corrected via 301d495. I'm a bit confused here, it seemed to happen because the elements positioned in absolute were outside of the screen. However, setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it was a bug or if we missed an interaction in the code 🤔
But the fix is simple and clean so good for me.
Hello,
<div class="col-12 col-lg-5">
<div class="h-100 p-2 p-lg-4 bg-dark">
<div class="pt-1 pt-lg-0 pe-3 pe-lg-4 pb-1 ps-2">
<h3 class="h1 mb-2 text-primary" **id=bidule"**>The best for my budget</h3>
<p class="h2 pt-1 pt-lg-2 mb-2">iPhone at a reduced price refurbished, with 1 year guarantly</p>
<p class="h5 pt-1 pt-lg-2 mb-3 text-primary">From 850 000 FCFA</p>
<a href="#" class="btn btn-secondary btn-inverse mt-1 mt-lg-2 mb-2" **id="truc" aria-labelledby="truc bidule"**>Find yours</a>
</div>
</div>
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello,
just invert the 2 id:
aria-labelledby="best-budget-FIND best-budget-TITLE"
and it'll be fine !
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Closes #1560.
Description
Things to know before reviewing it
From
and orange price and 0px between this price and the optionnal one under..bg-danger
.border-supporting-*
shouldn't exist since its example related. They have been transformed into.border-success
and.border-info
.Things to tackle outside of this PR
ul
/p
, ... with multiple of 5 ?Motivation & Context
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge