Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does this cause strange performance fluctuations ❓ 👊 💤 #4001

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Why does this cause strange performance fluctuations ❓ 👊 💤 #4001

wants to merge 1 commit into from

Conversation

Anzooooo
Copy link
Member

@Anzooooo Anzooooo commented Dec 8, 2024 •
edited
Loading

❓ ❓ ❓
I do not know why???

Why does this cause performance fluctuations?
In some use cases, it brought about a significant drop.
In theory, this will accelerate the replay of the Load 'forward fault' case, but it is unknown why it will affect other modules and bring more significant performance fluctuations.

@Anzooooo
fix(LoadQueueReplay): use more precise conditions for unblocking `for…
f051ada 
…warding fault`

It is not necessary to check whether the storequeue entry pointed to by sqidx is complete, because this entry is the store that follows this load.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: f051ada

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
f051ada 1.914 0.450 2.701 1.217 2.833 2.461 2.395 0.919 1.423 1.998 3.431 2.714 2.368 3.219

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
7d20eb3 1.959 0.450 2.686 1.226 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261
35477a7
493f6e1 1.959 0.450 2.686 1.224 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261
a60d667
7876e67

@Anzooooo Anzooooo changed the title fix(LoadQueueReplay): use more precise conditions for unblocking forwarding fault performance test -- onlyreplay Dec 8, 2024
@Anzooooo Anzooooo changed the title performance test -- onlyreplay performance test -- only replay Dec 8, 2024
@Anzooooo Anzooooo added bug Confirmed bugs question Question requiring answer problem Problem requiring help testing beta for CI test, not merged temporarily labels Dec 8, 2024
@Anzooooo Anzooooo changed the title performance test -- only replay Why does this cause strange performance fluctuations??? Dec 8, 2024
@Anzooooo Anzooooo changed the title Why does this cause strange performance fluctuations??? Why does this cause strange performance fluctuations ❓ Dec 8, 2024
@Anzooooo Anzooooo changed the title Why does this cause strange performance fluctuations ❓ Why does this cause strange performance fluctuations ❓ 👊 💤 Dec 8, 2024
@Anzooooo Anzooooo mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4e cz4e Awaiting requested review from cz4e cz4e will be requested when the pull request is marked ready for review cz4e is a code owner

@good-circle good-circle Awaiting requested review from good-circle good-circle will be requested when the pull request is marked ready for review good-circle is a code owner

@linjuanZ linjuanZ Awaiting requested review from linjuanZ linjuanZ will be requested when the pull request is marked ready for review linjuanZ is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Confirmed bugs problem Problem requiring help question Question requiring answer testing beta for CI test, not merged temporarily
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anzooooo @XiangShanRobot