Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TLB): avoid refill when one cycle before need_gpa #3985

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

good-circle
Copy link
Contributor

In previous design, refill.valid will be false when need_gpa is true. However, need_gpa is a reg so we add signal need_gpa_wire which will be true one cycle before need_gpa. refill.valid will be false either need_gpa or need_gpa_wire is true.

In previous design, refill.valid will be false when `need_gpa` is true. However, need_gpa is a reg so we add signal `need_gpa_wire` which will be true one cycle before need_gpa. refill.valid will be false either need_gpa or need_gpa_wire is true.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: a9771c3

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
a9771c3 1.959 0.450 2.686 1.224 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
e10e20c 1.959 0.450 2.687 1.228 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261
9fabe32 1.959 0.450 2.687 1.227 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261
8c9adf0 1.959 0.450 2.686 1.221 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.264
c92e74d
2e5ebf5 1.959 0.450 2.686 1.238 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261

Copy link
Member

@cebarobot cebarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@good-circle good-circle merged commit e9ba7f2 into master Dec 6, 2024
9 checks passed
@good-circle good-circle deleted the fix-gpf branch December 6, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants