Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Smstateen): fix access check when Smstateen extension enable. #3978

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix(Smstateen): fix access check when Smstateen extension enable. #3978

merged 2 commits into from
Dec 9, 2024

Conversation

NewPaulWalker
Copy link
Contributor

  • fix the access check for custom CSR and remove the illegal instruction check when accessing S-mode custom CSR from VS mode. This is because we can now use the Smstateen extension to control access to custom content at different privilege levels.

  • fix the misjudgment of the U-mode custom CSR.

  • fix the missing access check for the stopi CSR in AIA.

@NewPaulWalker NewPaulWalker force-pushed the fix-smstateen branch 2 times, most recently from 989b3a2 to a5cb4a1 Compare December 6, 2024 05:26
This was linked to issues Dec 6, 2024
ENVCFG in mstateen0 Does Not Control Access OpenXiangShan/NEMU#690
Closed
IMSIC in mstateen0 Does Not Control Access OpenXiangShan/NEMU#691
Closed
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 44fb7e1

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
44fb7e1 1.959 0.450 2.687 1.232 2.832 2.461 2.393 0.919 1.407 1.992 3.434 2.709 2.383 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
a60d667 1.959 0.450 2.686 1.234 2.832 2.461 2.393 0.919 1.407 1.992 3.434 2.709 2.383 3.261
7876e67 1.959 0.450 2.687 1.230 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261
e9ba7f2 1.959 0.450 2.686 1.226 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261
2bff79a 1.959 0.450 2.687 1.227 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261
02d2ded 1.959 0.450 2.686 1.228 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261

@NewPaulWalker
fix(Smstateen): fix access check when Smstateen extension enable.
ffc7351 
* fix the access check for custom CSR and remove the illegal instruction check
  when accessing S-mode custom CSR from VS mode. This is because we can now use
  the Smstateen extension to control access to custom content at different
  privilege levels.

* fix the misjudgment of the U-mode custom CSR.

* fix the missing access check for the stopi CSR in AIA.
@NewPaulWalker
ci: add ci tests for Smstateen extension.
7698128
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 7698128

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
7698128 1.959 0.450 2.687 1.237 2.832 2.461 2.393 0.919 1.407 1.992 3.434 2.709 2.383 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
fad7803 1.959 0.450 2.686 1.231 2.832 2.461 2.393 0.919 1.407 1.992 3.434 2.704 2.383 3.261
df65a16 1.959 0.450 2.686 1.238 2.832 2.461 2.393 0.919 1.407 1.992 3.434 2.709 2.383 3.261
7d20eb3 1.959 0.450 2.686 1.226 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261
35477a7
493f6e1 1.959 0.450 2.686 1.224 2.832 2.461 2.393 0.919 1.407 1.992 3.435 2.709 2.383 3.261

@Tang-Haojin Tang-Haojin merged commit ad15bdb into OpenXiangShan:master Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tang-Haojin Tang-Haojin Tang-Haojin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IMSIC in mstateen0 Does Not Control Access ENVCFG in mstateen0 Does Not Control Access
3 participants
@NewPaulWalker @XiangShanRobot @Tang-Haojin