Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

area(ittage): Split the Target into Region and Offset, with Region stored in registers and Offset still using SRAM #3935

Merged
merged 3 commits into from
Dec 5, 2024
Merged

area(ittage): Split the Target into Region and Offset, with Region stored in registers and Offset still using SRAM #3935

merged 3 commits into from
Dec 5, 2024

Conversation

sleep-zzz
Copy link
Contributor

No description provided.

@sleep-zzz
feat(ittag): Split the target into entries without storing high bits …
662d318 
…to reduce the area.
@sleep-zzz
feat(ittage): useful bit needs to be at the lowest bit.
7cd0377 
Additionally, if the Region is not written to rTable, the pointer value is invalid. In this case, it is necessary to raise the usePCRegion to prevent incorrect pointers from being written to SRAM in the ittage table write logic.
@sleep-zzz sleep-zzz requested a review from eastonman as a code owner November 26, 2024 03:15
@sleep-zzz sleep-zzz force-pushed the ittage-target-region branch from cdf258b to 2207168 Compare November 26, 2024 03:18
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 2207168

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
2207168 1.917 0.450 2.701 1.232 2.840 2.464 2.396 0.921 1.430 2.069 3.437 2.716 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
3956160
0d6f7fa 2.701 1.232 2.398 0.921 1.430 2.716 3.261
a5c77bc 1.917 0.450 2.701 1.230 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
d876189 1.917 0.450 2.701 1.230 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
9c13e96

eastonman
eastonman approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gao-Zeyu Gao-Zeyu merged commit 02d2ded into master Dec 5, 2024
9 checks passed
@Gao-Zeyu Gao-Zeyu deleted the ittage-target-region branch December 5, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastonman eastonman eastonman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sleep-zzz @XiangShanRobot @eastonman @Gao-Zeyu