Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdip: limit prefetchPtr range in ftq #2395

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fdip: limit prefetchPtr range in ftq #2395

merged 1 commit into from
Oct 23, 2023

Conversation

ssszwic
Copy link
Member

@ssszwic ssszwic commented Oct 19, 2023

No description provided.

@ssszwic ssszwic added the enhancement New feature in plan label Oct 19, 2023
@chenguokai chenguokai self-requested a review October 19, 2023 07:27
@ssszwic
Copy link
Member Author

ssszwic commented Oct 19, 2023

It appears that the MC test has failed, and I have already reported the issue to the @Ivyfeather.

@wakafa1
Copy link
Member

wakafa1 commented Oct 22, 2023

It should be fixed by OpenXiangShan/CoupledL2#73

@ssszwic
Copy link
Member Author

ssszwic commented Oct 23, 2023

It should be fixed by OpenXiangShan/CoupledL2#73

Understood. I am going to make a new commit.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: af9cbfa

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
af9cbfa 1.880 0.491 2.129 1.195 2.853 2.176 1.410 0.949 1.428 1.135 3.622 2.616 2.280 3.116

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
b21f711 2.151 0.954 1.411 3.132
772a742 0.491 2.158 1.206 2.902 2.182 1.411 0.955 1.442 1.138 3.622 2.615 2.280 3.136
7735eac 1.868 0.491 2.158 1.206 2.902 2.182 1.411 0.955 1.442 1.138 3.622 2.639 2.280 3.136
9672f0b 1.868 0.491 2.158 1.202 2.902 2.161 1.411 0.874 1.442 1.109 3.622 2.639 2.280 3.136
401876f 1.868 0.491 2.158 1.202 2.902 2.160 1.412 0.874 1.436 1.103 3.622 2.615 2.280 3.136
c157cf7 1.868 0.491 2.158 1.202 2.902 2.160 1.413 0.874 1.436 1.103 3.622 2.615 2.280 3.136
d3126fd 1.868 0.491 2.158 1.202 2.902 2.160 1.413 0.874 1.436 1.103 3.622 2.615 2.280 3.136
3711cf3 1.868 0.491 2.158 1.202 2.902 2.160 1.412 0.874 1.436 1.103 3.622 2.639 2.280 3.136
014ee79 1.868 0.491 2.158 1.202 2.902 2.160 1.413 0.874 1.436 1.103 3.622 2.615 2.280 3.136
fc00d28 1.880 0.491 2.158 1.196 2.906 2.163 1.415 0.882 1.436 1.104 3.646 2.652 2.279 3.155

@wakafa1
Copy link
Member

wakafa1 commented Oct 23, 2023

Is performance rise and fall expected？

@ssszwic
Copy link
Member Author

ssszwic commented Oct 23, 2023

Is performance rise and fall expected？

The erformance has some improvements relative to #2320 on SPEC06 coverage 0.3. And I am investigating the reasons for the performance decline on CI.

@wakafa1
Copy link
Member

wakafa1 commented Oct 23, 2023

Is performance rise and fall expected？

The erformance has some improvements relative to #2320 on SPEC06 coverage 0.3. And I am investigating the reasons for the performance decline on CI.

OK, that's fine. I think this PR can be merged once @chenguokai has reviewed

@chenguokai chenguokai merged commit f9c5154 into OpenXiangShan:master Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenguokai chenguokai chenguokai approved these changes

Assignees
No one assigned
Labels
enhancement New feature in plan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ssszwic @wakafa1 @XiangShanRobot @chenguokai