Skip to content

Commit

Permalink
fix(redirect): fix the blockCommit condition (#3992)
Browse files Browse the repository at this point in the history
  • Loading branch information
Anzooooo authored Dec 7, 2024
1 parent 493f6e1 commit 35477a7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/main/scala/xiangshan/backend/rob/Rob.scala
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,9 @@ class RobImp(override val wrapper: Rob)(implicit p: Parameters, params: BackendP
val deqFlushBlockCounter = Reg(UInt(3.W))
val deqFlushBlock = deqFlushBlockCounter(0)
val deqHasCommitted = io.commits.isCommit && io.commits.commitValid(0)
val deqHitRedirectReg = RegNext(io.redirect.valid && io.redirect.bits.robIdx === deqPtr)
// TODO *** WARNING ***
// Blocking commit. Don't change this before we fully understand the logic.
val deqHitRedirectReg = RegNext(io.redirect.valid && io.redirect.bits.robIdx === deqPtr) || RegNext(RegNext(io.redirect.valid && io.redirect.bits.robIdx === deqPtr))
val criticalErrorState = io.csr.criticalErrorState
when(deqNeedFlush && deqHitRedirectReg){
deqFlushBlockCounter := "b111".U
Expand Down

0 comments on commit 35477a7

Please sign in to comment.