Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat DAV and skill rework #4

Merged
merged 7 commits into from
Dec 22, 2023
Merged

feat DAV and skill rework #4

merged 7 commits into from
Dec 22, 2023

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Oct 31, 2023

First and foremost it's a about DAV intergration to sync alerts with a DAV server (tested with nextcloud), but comes with a multitude of improvements to make the skill a viable organizer

  • apart from the usual types (alarm, reminder, timer), added:
    • todos/tasks (aka. VTODO)
    • todo lists (organize todos in list form; eg shoppping list)
    • events (differentiation between reminder/event: length; better organisation due to overlap check)
  • extended input disambiguation as a combination of fuzzy matching and user reaffirmation
  • change alert properties (rather than create anew)
  • reschedule all different types
  • extended snooze mechanic
  • media player interface
  • GUI (alert) list display
  • own converse management

I guess it will be come down to a review by live testing, but things in particular to hash out/check for futureproofing are

  • session integration (session persists in the alerts' context)
  • OAuth integration (to serve from google,..)

To get a first glimpse, take a look at the README.
I've tried to get as much information in there as possible (without overburden the reader)

There is a good chance that i forgot something, given the mass ...
oh, and don't worry about the unittests, they will need adjustments when all is said and done.

@JarbasAl JarbasAl mentioned this pull request Oct 31, 2023
@JarbasAl JarbasAl added the enhancement New feature or request label Oct 31, 2023
@emphasize emphasize self-assigned this Nov 1, 2023
@builderjer
Copy link
Member

I have not seen a dual license that is Apache and GPLv3 as in caldev. I guess that is what is failing on the license tests.
I guess the question for that would be which license would apply here?

@JarbasAl JarbasAl merged commit b3e35df into dev Dec 22, 2023
2 of 9 checks passed
@JarbasAl JarbasAl deleted the feat/DAV branch December 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants