finish removing neon

[builderjer]

No description provided.

[builderjer]

not sure why the tests fail. I have tried, but this was my first look at the tests. The skill loads and works on raspbian-ovos

[JarbasAl]

This was meant as a PR for neon official skill, not intended to be a maintained fork, but seems it may take a while to drop the NeonSkill class so I think we can do this for now since the old Mycroft skill forks were archived

[builderjer]

Then can I merge?

[emphasize]

The first thing i see - that is probably consequetial - is that a test_fs should hold the files wrote to disk.
I don't know how Neon and OVOS skill classes diverge, but with the given alerts code you can't simply do
https://github.com/OpenVoiceOS/skill-alerts/blob/83c9a717d6829492b9c95485de6ff0acc76ab962/test/test_skill.py#L74-L75
(those are already initialized at that point)

If now the test_fs files are resetted in the process, this has no effect to the alerts.json that actually hold the informations
(which sits in ~/.local/share/mycroft/filesystem/skills/...)

As much as i like the extensive test approach, it is a fn nightmare to debug!
(No way without extensive knowledge or debug stepping through the code)

[emphasize]

also, watch out for timezones and testing locally. Sometimes utc is used, removing an alert instantly

[emphasize]

Just a heads up for everyone involved.
I'll do a sprint on my DAV skill-alerts to get another (potential) starting off point.

[JarbasAl]

replaced by #4