fix: active skills in session

[JarbasAl]

ovos-core will activate OCP_ID itself when intent triggers, we need to activate the real selected skill

Summary by CodeRabbit

• New Features
  • Enhanced session management during playback requests for improved skill activation.
• Bug Fixes
  • Improved accuracy of player state representation in the session.
• Documentation
  • Updated logging statements for better clarity and debugging.

[coderabbitai]

Walkthrough

The pull request modifies the OCPPipelineMatcher class in the ocp_pipeline/opm.py file, focusing on enhancing session management during play intent handling. The changes introduce session retrieval and skill activation within the handle_play_intent method, ensuring that the appropriate skill is activated based on the best match found during a play request. The modifications aim to improve the tracking and management of session state during playback interactions.

Changes

File	Change Summary
ocp_pipeline/opm.py	- Added session retrieval using SessionManager.get(message) - Implemented skill activation with sess.activate_skill(best.skill_id) - Minor logging statement adjustments

Sequence Diagram

sequenceDiagram
    participant User
    participant OCPPipelineMatcher
    participant SessionManager
    participant Skill

    User->>OCPPipelineMatcher: Send play intent message
    OCPPipelineMatcher->>SessionManager: Retrieve current session
    SessionManager-->>OCPPipelineMatcher: Return session
    OCPPipelineMatcher->>Skill: Activate best matched skill
    Skill-->>OCPPipelineMatcher: Skill activated

Loading

Possibly related PRs

• fix/search_from_GUI #30: Changes in the handle_play_search method of the OCPPipelineMatcher class, indicating ongoing improvements to message handling during playback requests.

Poem

🎵 In the realm of code, a rabbit's delight,
Sessions now dance with skills so bright!
Play intent flows with magical grace,
Matching melodies in every trace.
Hop, hop, hurray for pipeline's might! 🐰🎶

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7792511 and 91da98e.

📒 Files selected for processing (1)

• ocp_pipeline/opm.py (2 hunks)

🔇 Additional comments (2)

ocp_pipeline/opm.py (2)

584-584: LGTM: Session retrieval added correctly.

The session retrieval is properly placed before the search operation and will be used for skill activation and blacklisting.

---

614-616: LGTM: Session skill activation implemented correctly.

The changes properly implement skill activation in the session:

1. The best matching skill is activated instead of the default OCP_ID
2. The session is correctly serialized back into the message context

This fixes the issue described in the PR objectives.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.