fix:legacy_cps

[JarbasAl]

Summary by CodeRabbit

• New Features

  • Updated select_best method to a static method for improved functionality.

• Bug Fixes

  • Ensured handle_legacy_cps method aligns with the new static method usage.

• Deprecations

  • Deprecated match_fallback and match_legacy methods with guidance for alternatives.

[coderabbitai]

Walkthrough

The changes made to the OCPPipelineMatcher class in ocp_pipeline/opm.py involve converting the select_best method from an instance method to a static method, which modifies its invocation within the class. The handle_legacy_cps method in MycroftCPSLegacyPipeline has been updated accordingly to call the static method. Additionally, several methods have been deprecated, with guidance provided for alternative implementations, aiming to improve code clarity and maintainability.

Changes

File Path	Change Summary
ocp_pipeline/opm.py	- select_best changed from instance to static method.
	- handle_legacy_cps updated to call the static select_best.
	- match_fallback and match_legacy deprecated with recommendations for alternatives.

Poem

In the code where rabbits play,
A static method leads the way.
With deprecations, clear and bright,
Our paths are guided, pure delight!
Hopping through the lines we cheer,
For cleaner code, we hold so dear! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between baac4eb and 556c008.

📒 Files selected for processing (1)

• ocp_pipeline/opm.py (2 hunks)

🔇 Additional comments (2)

ocp_pipeline/opm.py (2)

942-943: LGTM! Good refactor to static method.

The conversion of select_best to a static method is appropriate as it's a pure utility function that doesn't depend on instance state. This change improves code organization and reusability.

---

1126-1126: LGTM! Correctly updated to use static method.

The call to select_best has been properly updated to use the static method syntax, maintaining compatibility with legacy Common Play Skills.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.