Refactor/converse messages #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added
enhancement
JarbasAl
reviewed
Oct 12, 2023
|
what the heck is it complaining about? |
JarbasAl
force-pushed
the
refactor/converse_messages
branch
from
14255ea to
1676dcf
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #371 +/- ##
==========================================
- Coverage 60.57% 59.88% -0.70%
==========================================
Files 13 13
Lines 1854 1857 +3
==========================================
- Hits 1123 1112 -11
- Misses 731 745 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the from core emitted message types of converse messages to directly address skills. (opposed to bulk messaging)
Furthermore only active skills will be eligible to initiate converse ping pong while collecting skills.
{self.skill_id}.converse.pingskill.converse.pong{self.skill_id}.converse.request{'utterances': list, 'lang': str}skill.converse.response{self.skill_id}.converse.get_response{'utterances': list, 'lang': str}This reduces the bus workload and resources consumed by skills. In direct comparison we`re increasing the responsiveness of converse up to 40% (dependent on the active skills)
Tests are adjusted and working (if both changes are pulled)
Skill counterpart PR: OpenVoiceOS/OVOS-workshop#144
Message spec PR: OpenVoiceOS/message_spec#2